[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 06 Aug 2018 19:38:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. IMPALA-6789: disable impersonation in hive in minicluster Due to bug of HADOOP-7050, users with dots in their username can't launch HiveServer2 in minicluster. To work arround this, we can set hive.server2.enable.doAs to false to disable impersonation in hive. Impala's authorization only depends on Sentry, so we can disable this without breaking any tests. This patch also quotes the group name in AuthorizationStmtTest#testShow to avoid syntax errors when group name contains dots. Test: * Build succeed with username quanlong.huang locally Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Reviewed-on: http://gerrit.cloudera.org:8080/9 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/resources/mysql-hive-site.xml.template M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2925/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 06 Aug 2018 16:26:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 06 Aug 2018 16:26:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 4: Code-Review+2 Seems fine. This only affects our Hive server configuration, which really only affects data load, so I don't think it's problematic. Fixing the underlying Hadoop issue (https://issues.apache.org/jira/browse/HADOOP-7050) by fixing the parsing of some files was also possible, but I accept that this was easier :) In terms of adding a Jenkins job for this, the cheapest way I know is to change "test-with-docker" to have different possibly usernames. Or to run Jenkins workers with different users. Both of those things currently seem to me like more work than it's worth. (In part, such a test would be testing our tests; our product doesn't see this.) -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 06 Aug 2018 16:26:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/195/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 05 Aug 2018 16:17:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9 to look at the new patch set (#4). Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. IMPALA-6789: disable impersonation in hive in minicluster Due to bug of HADOOP-7050, users with dots in their username can't launch HiveServer2 in minicluster. To work arround this, we can set hive.server2.enable.doAs to false to disable impersonation in hive. Impala's authorization only depends on Sentry, so we can disable this without breaking any tests. This patch also quotes the group name in AuthorizationStmtTest#testShow to avoid syntax errors when group name contains dots. Test: * Build succeed with username quanlong.huang locally Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/resources/mysql-hive-site.xml.template M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/9/4 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9/1/fe/src/test/resources/postgresql-hive-site.xml.template File fe/src/test/resources/postgresql-hive-site.xml.template: http://gerrit.cloudera.org:8080/#/c/9/1/fe/src/test/resources/postgresql-hive-site.xml.template@198 PS1, Line 198: : : : > Done The build in our internal Jenkins failed due to I move this into the Kerberos section. Configs in the Kerberos section will be removed if IMPALA_KERBERIZE is not set, see https://github.com/apache/impala/blob/3.0.0/bin/create-test-configuration.sh#L127-L129 . However, we need to disable impersonation in HiveServer2 in all situations in order to launch it. By the way, is it possible to set up a Jenkins job using a username containing DOTs (e.g. "impala.dev")? So our builds won't be broken by tests added in future. -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 05 Aug 2018 15:40:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 04 Aug 2018 17:40:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/188/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 04 Aug 2018 02:32:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9 to look at the new patch set (#3). Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. IMPALA-6789: disable impersonation in hive in minicluster Due to bug of HADOOP-7050, users with dots in their username can't launch HiveServer2 in minicluster. To work arround this, we can set hive.server2.enable.doAs to false to disable impersonation in hive. Impala's authorization only depends on Sentry, so we can disable this without breaking any tests. This patch also quotes the group name in AuthorizationStmtTest#testShow to avoid syntax errors when group name contains dots. Test: * Build succeed with username quanlong.huang locally Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/resources/mysql-hive-site.xml.template M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/9/3 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
