[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Sailesh Mukil (Code Review)]

Sailesh Mukil has abandoned this change. ( 
http://gerrit.cloudera.org:8080/10247 )

Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET
..


Abandoned

Not needed on 'master'
--
To view, visit http://gerrit.cloudera.org:8080/10247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
Gerrit-Change-Number: 10247
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10247 )

Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc@205
PS1, Line 205:  (e.getType() == TTransportException::NOT_OPEN &&
 :  strstr(e.what(), "ECONNRESET") != nullptr);
As discussed offline, this may not be applicable anymore with the recent 
upgrade of Thrift to 0.9.3 
(https://github.com/apache/thrift/blob/0.9.3/lib/cpp/src/thrift/transport/TSocket.cpp#L582-L584).

The upgrade of Thrift was only applied to master but not 2.x so this patch may 
still be valid for 2.x.

I wonder if it makes sense to #ifdef it in the code somehow.



--
To view, visit http://gerrit.cloudera.org:8080/10247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
Gerrit-Change-Number: 10247
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Mon, 30 Apr 2018 23:00:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10247


Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET
..

IMPALA-6908: IsConnResetTException() should include ECONNRESET

The utility function IsConnResetTException() attempted to match error
strings from RPCs that fail due to the remote end resetting the connection
for any reason. However, it did not take care of the situation where
ECONNRESET was sent on a cluster not using TLS.

This patch adds this case as well and adds a custom cluster fault
injection test to test the same.

Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
---
M be/src/rpc/thrift-util.cc
M be/src/testutil/fault-injection-util.cc
M be/src/testutil/fault-injection-util.h
M tests/custom_cluster/test_rpc_exception.py
4 files changed, 19 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/10247/1
--
To view, visit http://gerrit.cloudera.org:8080/10247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2
Gerrit-Change-Number: 10247
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil