[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Alice Fan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12926 Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. IMPALA-7031: Cancel action of debug page should not unregister query When a running query is cancelled from impalad WebUI (debug page), the client will receive an invalid query handle exception on the next fetch/getOperationStatus attempts. The patch modified ImpalaHttpHandler, "Cancel" button will only cancel the query instead of unregister it. Testing: - Added test_cancel_query_from_debug_page at test_web_pages.py Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 --- M be/src/service/impala-http-handler.cc M tests/webserver/test_web_pages.py 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12926/1 -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12926/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12926/1/tests/webserver/test_web_pages.py@543 PS1, Line 543: 0 flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 03 Apr 2019 22:57:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12926 to look at the new patch set (#2). Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. IMPALA-7031: Cancel action of debug page should not unregister query When a running query is cancelled from impalad WebUI (debug page), the client will receive an invalid query handle exception on the next fetch/getOperationStatus attempts. The patch modified ImpalaHttpHandler, "Cancel" button will only cancel the query instead of unregister it. Testing: - Added test_cancel_query_from_debug_page at test_web_pages.py Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 --- M be/src/service/impala-http-handler.cc M tests/webserver/test_web_pages.py 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12926/2 -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2629/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 03 Apr 2019 23:37:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2630/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 03 Apr 2019 23:34:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12926 to look at the new patch set (#4). Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. IMPALA-7031: Cancel action of debug page should not unregister query When a running query is cancelled from the Cancel button of debug page (impalad WebUI), it will unregister the query. But the client is unaware of the query is unregistered, it will get error/exception on other attempts. The patch updated the ImpalaHttpHandler to make "Cancel" button will only cancel the query instead of unregister it. Testing: - Added a test to test_web_pages.py - Run all webserver tests Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 --- M be/src/service/impala-http-handler.cc M tests/webserver/test_web_pages.py 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12926/4 -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 4 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12926 to look at the new patch set (#3). Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. IMPALA-7031: Cancel action of debug page should not unregister query When a running query is cancelled from the Cancel button of debug page (impalad WebUI), it will unregister the query. But the client is unaware of the query is unregistered, it will get error/exception on other attempts. The patch updated the ImpalaHttpHandler to make "Cancel" button will only cancel the query instead of unregister it. Testing: - Added a test to test_web_pages.py to test if query is unregistered when cancel from debug page - Run all webserver tests Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 --- M be/src/service/impala-http-handler.cc M tests/webserver/test_web_pages.py 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12926/3 -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2657/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 05 Apr 2019 01:58:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/12926/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12926/4//COMMIT_MSG@9 PS4, Line 9: When a running query is cancelled from the Cancel button of debug nit: queries debug page http://gerrit.cloudera.org:8080/#/c/12926/4//COMMIT_MSG@10 PS4, Line 10: But the client : is unaware of the query is unregistered, it will get error/exception : on other attempts This can result in a scenario where a client that has a reference to the query handle is unaware that the query has been unregistered via the debug page, and attempts to run an operation on that query handle but encounters and error instead. http://gerrit.cloudera.org:8080/#/c/12926/4//COMMIT_MSG@12 PS4, Line 12: The patch updated the ImpalaHttpHandler to make : "Cancel" button will only cancel the query instead of : unregister it This patch updates the cancel http endpoint to only cancel the query. http://gerrit.cloudera.org:8080/#/c/12926/4//COMMIT_MSG@18 PS4, Line 18: Run nit: ran http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@537 PS4, Line 537: Test if unregister query when press "Cancel" button on : the debug page (impalad WebUI) Verify that the cancel http endpoint does not unregister the query http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@540 PS4, Line 540: cancel cancels http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@547 PS4, Line 547: assert "Query cancellation successful" in responses[0].text assert "Query cancellation successful" in responses[0].text, responses[0].text http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@548 PS4, Line 548: # After the query is successfully canceled, the client runs a get_state operation to verify that the query id is still registered http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@551 PS4, Line 551: unregistered nit not necessarily the case, could be anything. Just say something like "Encountered unexpected exception. Query might be unregisted already. Exception: " http://gerrit.cloudera.org:8080/#/c/12926/4/tests/webserver/test_web_pages.py@552 PS4, Line 552: finally: self.client.close(query_handle) -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 4 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 09 Apr 2019 17:35:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12926 to look at the new patch set (#5). Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. IMPALA-7031: Cancel action of debug page should not unregister query When a running query is canceled from the Cancel button of queries debug page (impalad WebUI), the query will be unregistered. This can result in a scenario where a client that has a reference to the query handle is unaware that the query has been unregistered via the debug page, and attempts to run an operation on that query handle but encounters and error instead. This patch updates the cancel http endpoint to only cancel the query. Testing: - Added a test to test_web_pages.py - Ran all webserver tests Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 --- M be/src/service/impala-http-handler.cc M tests/webserver/test_web_pages.py 2 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12926/5 -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 5 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2713/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 5 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 09 Apr 2019 22:50:34 + Gerrit-HasComments: No
