[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..

IMPALA-7071: make get_fs_path() idempotent

This avoids future errors like IMPALA-7068.

Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Reviewed-on: http://gerrit.cloudera.org:8080/10517
Reviewed-by: Dan Hecht 
Tested-by: Impala Public Jenkins 
---
A tests/infra/test_utils.py
M tests/util/filesystem_utils.py
2 files changed, 37 insertions(+), 2 deletions(-)

Approvals:
  Dan Hecht: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 08 Jun 2018 00:14:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2622/


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 07 Jun 2018 21:04:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 3:

Sure


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 07 Jun 2018 21:04:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 4: Code-Review+2

Carry +2


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 07 Jun 2018 21:04:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 3:

Do you want to go ahead and merge this? Seems low risk.


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 07 Jun 2018 19:23:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 19:01:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Hello Michael Brown, Sailesh Mukil, David Knupp,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10517

to look at the new patch set (#3).

Change subject: IMPALA-7071: make get_fs_path() idempotent
..

IMPALA-7071: make get_fs_path() idempotent

This avoids future errors like IMPALA-7068.

Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
---
A tests/infra/test_utils.py
M tests/util/filesystem_utils.py
2 files changed, 37 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10517/3
--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[David Knupp (Code Review)]

David Knupp has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py
File tests/infra/test_utils.py:

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@25
PS1, Line 25:   path = "/fake-warehouse"
> Apparently not.
Top level test functions are perfectly acceptable, and in fact preferred for 
simple, straightforward unit tests like this.



--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 18:54:16 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Hello Michael Brown, Sailesh Mukil, David Knupp,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10517

to look at the new patch set (#2).

Change subject: IMPALA-7071: make get_fs_path() idempotent
..

IMPALA-7071: make get_fs_path() idempotent

This avoids future errors like IMPALA-7068.

Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
---
A tests/infra/test_utils.py
M tests/util/filesystem_utils.py
2 files changed, 38 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10517/2
--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py
File tests/infra/test_utils.py:

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@20
PS1, Line 20: import pytest
> You shouldn't need this.
Done


http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@25
PS1, Line 25: class TestUtils(ImpalaTestSuite):
> Is there a reason why we need a class here, or inheritance from the ImpalaT
Apparently not.



--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 18:51:55 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[David Knupp (Code Review)]

David Knupp has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py
File tests/infra/test_utils.py:

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@25
PS1, Line 25: class TestUtils(ImpalaTestSuite):
Is there a reason why we need a class here, or inheritance from the 
ImpalaTestSuite?



--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 18:44:56 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 1:

(1 comment)

Looks fine.

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py
File tests/infra/test_utils.py:

http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@20
PS1, Line 20: import pytest
You shouldn't need this.



--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 18:44:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10517 )

Change subject: IMPALA-7071: make get_fs_path() idempotent
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 25 May 2018 18:35:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

[Dan Hecht (Code Review)]

Dan Hecht has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10517


Change subject: IMPALA-7071: make get_fs_path() idempotent
..

IMPALA-7071: make get_fs_path() idempotent

This avoids future errors like IMPALA-7068.

Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
---
A tests/infra/test_utils.py
M tests/util/filesystem_utils.py
2 files changed, 42 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10517/1
--
To view, visit http://gerrit.cloudera.org:8080/10517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388
Gerrit-Change-Number: 10517
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht