[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Thu, 29 Oct 2020 10:35:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. IMPALA-7097 Print EC info in the query plan and profile This fix added the functionality to show the number of erasure coded files and the total size of such files in the scan node in the query plan and profile. Shown below are two examples for the HDFS file system. Non-partitioned table: 00:SCAN HDFS [default.test_show_ec_nonpart, RANDOM] HDFS partitions=1/1 files=2 size=1.65KB erasure coded: files=2 size=1.65KB stored statistics: Partitioned table: 00:SCAN HDFS [default.test_show_ec_part] HDFS partitions=4/4 files=4 size=2.36KB erasure coded: files=3 size=1.77KB row-size=12B cardinality=999 Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Reviewed-on: http://gerrit.cloudera.org:8080/16587 Reviewed-by: Aman Sinha Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 28 insertions(+), 2 deletions(-) Approvals: Aman Sinha: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 9 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6615/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Thu, 29 Oct 2020 05:08:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Thu, 29 Oct 2020 05:05:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Wed, 28 Oct 2020 22:30:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Mon, 26 Oct 2020 16:33:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7557/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Mon, 26 Oct 2020 16:30:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Qifan Chen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. IMPALA-7097 Print EC info in the query plan and profile This fix added the functionality to show the number of erasure coded files and the total size of such files in the scan node in the query plan and profile. Shown below are two examples for the HDFS file system. Non-partitioned table: 00:SCAN HDFS [default.test_show_ec_nonpart, RANDOM] HDFS partitions=1/1 files=2 size=1.65KB erasure coded: files=2 size=1.65KB stored statistics: Partitioned table: 00:SCAN HDFS [default.test_show_ec_part] HDFS partitions=4/4 files=4 size=2.36KB erasure coded: files=3 size=1.77KB row-size=12B cardinality=999 Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16587/7 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 6: Code-Review+1 (1 comment) Just a small nitpick. http://gerrit.cloudera.org:8080/#/c/16587/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16587/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1489 PS6, Line 1489: Erasure nit: all the other options are printed in lower case. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shant Hovsepian Gerrit-Comment-Date: Thu, 22 Oct 2020 14:16:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 20 Oct 2020 18:23:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7488/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 20 Oct 2020 00:11:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Qifan Chen has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. IMPALA-7097 Print EC info in the query plan and profile This fix added the functionality to show the number of erasure coded files and the total size of such files in the scan node in the query plan and profile. Shown below are two examples for the HDFS file system. Non-partitioned table: 00:SCAN HDFS [default.test_show_ec_nonpart, RANDOM] HDFS partitions=1/1 files=2 size=1.65KB Erasure coded: files=2 size=1.65KB stored statistics: Partitioned table: 00:SCAN HDFS [default.test_show_ec_part] HDFS partitions=4/4 files=4 size=2.36KB Erasure coded: files=3 size=1.77KB row-size=12B cardinality=999 Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16587/6 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 5: Code-Review+1 A few more nits, otherwise LGTM. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 19 Oct 2020 17:12:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1489 PS1, Line 1489: ErasureCodeTemplate nit: should be erasureCodeTemplate http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1503 PS1, Line 1503: Long > The use of Long is intended to handle null possibly returned from the get() just use Map#containsKey instead of doing the complex null handling. http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1511 PS1, Line 1511: No report : // on EC related info. > Did some more research in this area. It appears the reason for 0 files outp Done -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 19 Oct 2020 17:11:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7465/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Thu, 15 Oct 2020 17:19:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. IMPALA-7097 Print EC info in the query plan and profile This fix added the functionality to show the number of erasure coded files and the total size of such files in the scan node in the query plan and profile. Shown below are two examples for the HDFS file system. Non-partitioned table: 00:SCAN HDFS [default.test_show_ec_nonpart, RANDOM] HDFS partitions=1/1 files=2 size=1.65KB Erasure coded: files=2 size=1.65KB stored statistics: Partitioned table: 00:SCAN HDFS [default.test_show_ec_part] HDFS partitions=4/4 files=4 size=2.36KB Erasure coded: files=3 size=1.77KB row-size=12B cardinality=999 Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16587/5 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7455/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Wed, 14 Oct 2020 18:00:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. IMPALA-7097 Print EC info in the query plan and profile This fix added the functionality to show the number of erasure coded files and the total size of such files in the scan node in the query plan and profile. Shown below is one example for the HDFS file system. 00:SCAN HDFS [default.foo_ec, RANDOM] HDFS partitions=1/1 files=2 size=1.65KB Erasure coded: files=2 size=1.65KB stored statistics: Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16587/4 -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Sahil Takiar
