[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 06 Jun 2018 01:58:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. IMPALA-7105. Ensure fe tests pass when running standalone CatalogTest and HdfsStorageDescriptorTest would fail when run individually because they relied on various initialization that only occurs when FeSupport is loaded. These tests weren't explicitly loading FeSupport, but instead relying on earlier tests in 'mvn test' to do so. Tested that, with this change, I'm able to run these tests in Eclipse and they pass. I also tested 'mvn test -DreuseForks=false' and verified that all tests now pass in this mode. Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Reviewed-on: http://gerrit.cloudera.org:8080/10570 Reviewed-by: Vuk Ercegovac Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/FeSupport.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2602/ -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 05 Jun 2018 22:36:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Code-Review+2 tried -DreuseForks=false with the change. thanks! -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 01 Jun 2018 07:00:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10570/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/10570/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@40 PS1, Line 40: import org.apache.impala.service.FeSupport; oops, don't need this import -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 01 Jun 2018 04:46:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10570 Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. IMPALA-7105. Ensure fe tests pass when running standalone CatalogTest and HdfsStorageDescriptorTest would fail when run individually because they relied on various initialization that only occurs when FeSupport is loaded. These tests weren't explicitly loading FeSupport, but instead relying on earlier tests in 'mvn test' to do so. Tested that, with this change, I'm able to run these tests in Eclipse and they pass. I also tested 'mvn test -DreuseForks=false' and verified that all tests now pass in this mode. Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 --- M fe/src/main/java/org/apache/impala/service/FeSupport.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java 4 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10570/1 -- To view, visit http://gerrit.cloudera.org:8080/10570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555 Gerrit-Change-Number: 10570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon