[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. IMPALA-7315: fix test_update_with_clear_entries_flag race We need to wait for the subscriber to process the second update in order to guarantee that the first update for that subscriber has been applied. Otherwise there is a race window where the second subscriber may see the older version of the statestore topic. Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Reviewed-on: http://gerrit.cloudera.org:8080/10986 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/statestore/test_statestore.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 09:49:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 06:35:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2841/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 06:35:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2837/ -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 02:00:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2837/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:51:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2835/ -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:51:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:51:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:36:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2835/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:36:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10986 ) Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 22:23:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7315: fix test update with clear entries flag race
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10986 Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race .. IMPALA-7315: fix test_update_with_clear_entries_flag race We need to wait for the subscriber to process the second update in order to guarantee that the first update for that subscriber has been applied. Otherwise there is a race window where the second subscriber may see the older version of the statestore topic. Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 --- M tests/statestore/test_statestore.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/10986/1 -- To view, visit http://gerrit.cloudera.org:8080/10986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454 Gerrit-Change-Number: 10986 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
