[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. IMPALA-7329: Blacklist CDH Maven snapshots repository The Impala development bootstrapping depends on CDH Maven snapshots which transitively pull dependencies from other repositories which can cause the build to be non-reproducible, e.g. IMPALA-7316. This patch makes the build to be reproducible by blacklisting cdh.snapshots.repo so that Maven does not accidentally downloads the latest CDH snapshots when running a build, which can cause incompatibility issues. Testing: - Ran core tests with CDH_BUILD_NUMBER=422770 and did not hit the issue described in IMPALA-7316 Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Reviewed-on: http://gerrit.cloudera.org:8080/10999 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M impala-parent/pom.xml 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 31 Jul 2018 02:49:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2884/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 23:22:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 23:22:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: No Builds Executed -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 22:34:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: > Patch Set 3: Code-Review+1 > > (1 comment) > > Thanks. This looks fine to me. Did you confirm with mvn -X or something what > repos do and don't get talked to? I did. I also double check the $HOME/.m2 directory to make sure no maven-metadata-cdh.snapshots.repo.xml was created. -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 19:51:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 19:55:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. IMPALA-7329: Blacklist CDH Maven snapshots repository The Impala development bootstrapping depends on CDH Maven snapshots which transitively pull dependencies from other repositories which can cause the build to be non-reproducible, e.g. IMPALA-7316. This patch makes the build to be reproducible by blacklisting cdh.snapshots.repo so that Maven does not accidentally downloads the latest CDH snapshots when running a build, which can cause incompatibility issues. Testing: - Ran core tests with CDH_BUILD_NUMBER=422770 and did not hit the issue described in IMPALA-7316 Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 --- M impala-parent/pom.xml 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10999/4 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Patch Set 3: Code-Review+1 (1 comment) Thanks. This looks fine to me. Did you confirm with mvn -X or something what repos do and don't get talked to? http://gerrit.cloudera.org:8080/#/c/10999/3/impala-parent/pom.xml File impala-parent/pom.xml: http://gerrit.cloudera.org:8080/#/c/10999/3/impala-parent/pom.xml@73 PS3, Line 73: In this case, please move some of your commit message into a here. It's not obvious that lines 78 and 81 are doing blacklisting here, so let's be pedantic and talk about it. -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 30 Jul 2018 17:25:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Fredy Wijaya has removed Jim Apple from this change. ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. Removed reviewer Jim Apple. -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10999 ) Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. IMPALA-7329: Blacklist CDH Maven snapshots repository The Impala development boostrapping depends on CDH Maven snapshots which transitively pull dependencies from other repositories which can cause the build to be non-reproducible, e.g. IMPALA-7316. This patch makes the build to be reproducible by blacklisting cdh.snapshots.repo so that Maven does not accidentally downloads the latest CDH snapshots when running a build, which can cause incompatibility issues. Testing: - Ran core tests with CDH_BUILD_NUMBER=422770 and did not hit the issue described in IMPALA-7316 Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 --- M impala-parent/pom.xml 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10999/3 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7329: Blacklist CDH Maven snapshots repository
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10999 Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository .. IMPALA-7329: Blacklist CDH Maven snapshots repository Impala depends on CDH Maven snapshots which transitively pull dependencies from other repositories which can cause the build to be non-reproducible, e.g. IMPALA-7316. This patch makes the build to be reproducible by blacklisting cdh.snapshots.repo so that Maven does not accidentally downloads the latest CDH snapshots when running a build, which can cause incompatibility issues. Testing: - Ran core tests with CDH_BUILD_NUMBER=422770 and did not hit the issue described in IMPALA-7316 Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 --- M impala-parent/pom.xml 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10999/2 -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya