[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-10 Thread Bikramjeet Vig (Code Review) 
Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 5: Code-Review+1

(2 comments)

Looks good to me! @Tim can you +2 if you dont see any major concerns?

http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG@7
PS5, Line 7: IMPALA-7335: Add logs HdfsScanNode to debug the issue
   :
   : This log would help determine the condition when the test failures
   : occur.
could you add some more details to the log message. See 
https://gerrit.cloudera.org/#/c/10851/ for some reference


http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc@333
PS5, Line 333: #ifndef NDEBUG
 :   VLOG_QUERY << "Non-ok status returned by ProcessSplit = " 
<< status.msg().msg()
 :  << " for Scan node (id=" << id()
 :  << ", status_ = " << (status_.ok() ? "ok" : 
status_.msg().msg())
 :  << ", done_ = " << (done_ ? "1" : "0") << ")";
 : #endif
if you plan to remove this after you figure out the cause, you can add a TODO 
here, with the JIRA ID so it doesnt get unnoticed.



--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 10 Aug 2018 23:07:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/289/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 10 Aug 2018 21:46:32 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-10 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 5:

I have been trying to reproduce this issue and IMPALA-7418 (since the failures 
seem similar) locally, without any luck. I think this log might help in 
understanding the exact cause of the failure and might also help reproduce it 
deterministically.

> Patch Set 4:
>
> I'll let you decide based on whether it will be useful for your debugging. It 
> sounded like you had a good theory but if this will help you confirm it we 
> should go ahead for now and remove it later.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 10 Aug 2018 21:14:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-10 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..

IMPALA-7335: Add logs HdfsScanNode to debug the issue

This log would help determine the condition when the test failures
occur.

Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/11174/5
--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 4:

I'll let you decide based on whether it will be useful for your debugging. It 
sounded like you had a good theory but if this will help you confirm it we 
should go ahead for now and remove it later.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 23:08:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/276/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 22:38:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Pooja Nilangekar (Code Review) 
Hello Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11174

to look at the new patch set (#4).

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..

IMPALA-7335: Add logs HdfsScanNode to debug the issue

This log would help determine the condition when the test failures
occur.

Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/11174/4
--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 2:

(1 comment)

This may be less necessary now - I have a local repro of a similar issue: 
IMPALA-7418

http://gerrit.cloudera.org:8080/#/c/11174/2/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/2/be/src/exec/hdfs-scan-node.cc@333
PS2, Line 333: LOG(INFO)
VLOG_QUERY.

I think we should also wrap it in #ifndef NDEBUG so we don't run it on release 
builds.



--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 20:40:10 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/266/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 17:55:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc@331
PS1, Line 331: status
> Might help to print this out too just to see if it's CANCELLED or something
Done


http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc@334
PS1, Line 334: << " for Scan node (id=" << id() << ", status_ = 
" << status_.msg().msg()
> tab used for whitespace
Done



--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 17:21:12 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-09 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..

IMPALA-7335: Add logs HdfsScanNode to debug the issue

This log would help determine the condition when the test failures
occur.

Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/11174/2
--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/262/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 01:25:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-08 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc@331
PS1, Line 331: status
Might help to print this out too just to see if it's CANCELLED or something 
else.



--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 01:15:17 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/1/be/src/exec/hdfs-scan-node.cc@334
PS1, Line 334:  << ", done_ = " << (done_ ? "1" : "0") << ")";
tab used for whitespace



--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 09 Aug 2018 01:12:27 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-08 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11174


Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue
..

IMPALA-7335: Add logs HdfsScanNode to debug the issue

This log would help determine the condition when the test failures
occur.

Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/11174/1
--
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar