[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/107/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 16 Oct 2018 22:48:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11704 Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. IMPALA-7715: [DOCS] Better descriptions for conditional functions - Updated the descriptions for ISTRUE, ISFALSE, NONULVALUE, NULLVALUE. Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 --- M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml 2 files changed, 74 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11704/1 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11704 to look at the new patch set (#2). Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. IMPALA-7715: [DOCS] Better descriptions for conditional functions - Updated the descriptions for ISTRUE, ISFALSE, NONULVALUE, NULLVALUE. - Updated several function names to use caps. Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 --- M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml 2 files changed, 74 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11704/2 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/107/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Tue, 16 Oct 2018 22:57:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 2: (4 comments) Thanks for making these changes so quickly! A few minor suggestions. http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml File docs/topics/impala_conditional_functions.xml: http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@341 PS2, Line 341: FALSE if the expression is true or NULL. Should the other refs to boolean constants be called out? "is false" --> "is FALSE"? Also for true? http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@345 PS2, Line 345: After reading your other change, it appears we support IS FALSE. So, we might add: "Same as the IS FALSE operator." http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@445 PS2, Line 445: FALSE if the expression is false or NULL. "an expression" --> "the expression". Code font for true and false. http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@449 PS2, Line 449: Add comment "Is same as the IS TRUE operator." Maybe also do this for "isnottrue() - IS NOT TRUE" and "isnotfalse() - IS NOT FALSE" -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 01:28:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml File docs/topics/impala_conditional_functions.xml: http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@341 PS2, Line 341: FALSE if the expression is true or NULL. > Should the other refs to boolean constants be called out? "is false" --> "i WIP. In this file, I changed them to upper case. I just started converting the keywords and function names to be uppercase. It will take a while to convert them all in the function docs. http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@345 PS2, Line 345: > After reading your other change, it appears we support IS FALSE. So, we mig Done http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@445 PS2, Line 445: FALSE if the expression is false or NULL. > "an expression" --> "the expression". Code font for true and false. Done http://gerrit.cloudera.org:8080/#/c/11704/2/docs/topics/impala_conditional_functions.xml@449 PS2, Line 449: > Add comment "Is same as the IS TRUE operator." Done -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 02:17:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Hello Paul Rogers, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11704 to look at the new patch set (#3). Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. IMPALA-7715: [DOCS] Better descriptions for conditional functions - Updated the descriptions for ISTRUE, ISFALSE, NONULVALUE, NULLVALUE. - Updated several function names to use caps. Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 --- M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml 2 files changed, 115 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11704/3 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/108/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 02:17:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/108/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 02:20:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 3: Code-Review+1 Looks good. The changes wonderfully address the ambiguity in the original docs. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 18:41:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. IMPALA-7715: [DOCS] Better descriptions for conditional functions - Updated the descriptions for ISTRUE, ISFALSE, NONULVALUE, NULLVALUE. - Updated several function names to use caps. Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Reviewed-on: http://gerrit.cloudera.org:8080/11704 Tested-by: Impala Public Jenkins Reviewed-by: Paul Rogers Reviewed-by: Alex Rodoni --- M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml 2 files changed, 115 insertions(+), 89 deletions(-) Approvals: Impala Public Jenkins: Verified Paul Rogers: Looks good to me, but someone else must approve Alex Rodoni: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers
[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc90d62645730d2674bcb3af614863aa92b92f6 Gerrit-Change-Number: 11704 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Wed, 17 Oct 2018 18:49:53 + Gerrit-HasComments: No
