[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-13 Thread Paul Rogers (Code Review) 
Paul Rogers has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging
..


Patch Set 1:

Dry-run tests passed: https://jenkins.impala.io/job/pre-review-test/224/


--
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Paul Rogers 
Gerrit-Comment-Date: Tue, 13 Nov 2018 21:44:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1348/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 09 Nov 2018 19:52:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-09 Thread Paul Rogers (Code Review) 
Paul Rogers has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11915


Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging
..

IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

Builds on IMPALA-7808 with several additional refactorings:

* IMPALA-7808 minimized code changes. This change cleans up the
  new functions, removing if's and merging the "aggregation"
  function with the body of the new analyze() function.
* Creates a new "QueryAnalyzer" class in the QueryStmt class.
* Changed the SelectStmt's SelectAnalyzer to extend the new
  QueryAnalyzer. This allows removing some "analyzer"
  parameters.
* Played the same trick for other classes that extend
  QueryStmt.

This is all refactoring: there is no functional change.

Testing: Reran existing tests to ensure that functionality
remained unchanged.

Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java
M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java
M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/Subquery.java
M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
M fe/src/main/java/org/apache/impala/analysis/WithClause.java
8 files changed, 218 insertions(+), 202 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/11915/1
--
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers