[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues: * If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available. This is mostly an issue during testing. * The generated SQL does not follow the CREATE TABLE syntax. For example, the signature and return value are provided for Java functions, but should not be. * Unlike other statements, this one is generated with a trailing newline. * ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement separator. These are all minor issues, but we might as well fix the code to work as intended. Testing: * Added a new unit tests to verify the behavior (no tested existed previously.) * Re-ran all FE tests. Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Reviewed-on: http://gerrit.cloudera.org:8080/12014 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java M fe/src/main/java/org/apache/impala/catalog/Function.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M tests/common/test_result_verifier.py M tests/metadata/test_ddl.py 9 files changed, 224 insertions(+), 41 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 7 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 11 Dec 2018 02:47:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3547/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 10 Dec 2018 22:53:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 10 Dec 2018 22:53:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 5: Code-Review+2 Thanks for the fixes and the new tests. -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Dec 2018 18:30:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 5: Passed pre-review tests: https://jenkins.impala.io/job/pre-review-test/240/ -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Comment-Date: Mon, 03 Dec 2018 02:39:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1508/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 02 Dec 2018 18:27:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#5). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues: * If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available. This is mostly an issue during testing. * The generated SQL does not follow the CREATE TABLE syntax. For example, the signature and return value are provided for Java functions, but should not be. * Unlike other statements, this one is generated with a trailing newline. * ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement separator. These are all minor issues, but we might as well fix the code to work as intended. Testing: * Added a new unit tests to verify the behavior (no tested existed previously.) * Re-ran all FE tests. Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java M fe/src/main/java/org/apache/impala/catalog/Function.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M tests/common/test_result_verifier.py M tests/metadata/test_ddl.py 9 files changed, 224 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12014/5 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1506/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 02 Dec 2018 05:10:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#4). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues: * If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available. This is mostly an issue during testing. * The generated SQL does not follow the CREATE TABLE syntax. For example, the signature and return value are provided for Java functions, but should not be. * Unlike other statements, this one is generated with a trailing newline. * ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement separator. These are all minor issues, but we might as well fix the code to work as intended. Testing: * Added a new unit tests to verify the behavior (no tested existed previously.) * Re-ran all FE tests. Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java M fe/src/main/java/org/apache/impala/catalog/Function.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test M tests/common/test_result_verifier.py M tests/metadata/test_ddl.py 8 files changed, 224 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12014/4 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1500/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 01 Dec 2018 04:26:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1499/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 01 Dec 2018 04:14:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#3). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues: * If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available. This is mostly an issue during testing. * The generated SQL does not follow the CREATE TABLE syntax. For example, the signature and return value are provided for Java functions, but should not be. * Unlike other statements, this one is generated with a trailing newline. * ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement separator. These are all minor issues, but we might as well fix the code to work as intended. Testing: * Added a new unit tests to verify the behavior (no tested existed previously.) * Re-ran all FE tests. Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java M fe/src/main/java/org/apache/impala/catalog/Function.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test M tests/common/test_result_verifier.py M tests/metadata/test_ddl.py 8 files changed, 224 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12014/3 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues: * If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available. This is mostly an issue during testing. * The generated SQL does not follow the CREATE TABLE syntax. For example, the signature and return value are provided for Java functions, but should not be. * Unlike other statements, this one is generated with a trailing newline. * ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement separator. These are all minor issues, but we might as well fix the code to work as intended. Testing: * Added a new unit tests to verify the behavior (no tested existed previously.) * Re-ran all FE tests. Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java M fe/src/main/java/org/apache/impala/catalog/Function.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test M tests/common/test_result_verifier.py M tests/metadata/test_ddl.py 8 files changed, 214 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12014/2 -- To view, visit http://gerrit.cloudera.org:8080/12014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c Gerrit-Change-Number: 12014 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers
[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/12014 )
Change subject: IMPALA-7907: Fix ScalarFunction.toSql()
..
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java:
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@86
PS2, Line 86: Function fn = Function.createFunction("mydb", "fn1", args,
Type.INT, false, TFunctionBinaryType.JAVA);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@96
PS2, Line 96: Function fn = new ScalarFunction(new FunctionName("mydb",
"fn1"), args, Type.INT, false);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@105
PS2, Line 105: ScalarFunction fn = new ScalarFunction(new
FunctionName("mydb", "fn1"), args, Type.INT, false);
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@118
PS2, Line 118: ScalarFunction fn = new ScalarFunction(new
FunctionName("mydb", "fn1"), args, Type.INT, false);
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@131
PS2, Line 131: ScalarFunction fn = new ScalarFunction(new
FunctionName("mydb", "fn1"), args, Type.INT, false);
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@145
PS2, Line 145: ScalarFunction fn = new ScalarFunction(new
FunctionName("mydb", "fn1"), args, Type.INT, false);
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@163
PS2, Line 163: AggregateFunction fn = new AggregateFunction(new
FunctionName("mydb", "fn1"), args, Type.BIGINT, false);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@181
PS2, Line 181: AggregateFunction fn = new AggregateFunction(new
FunctionName("mydb", "fn1"), args, Type.BIGINT, false);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@208
PS2, Line 208: ScalarFunction fn1 = new ScalarFunction(new
FunctionName("mydb", "fn1"), new ArrayList<>(), Type.INT, false);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/12014/2/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@214
PS2, Line 214: ScalarFunction fn2 = new ScalarFunction(new
FunctionName("mydb", "fn2"), args, Type.INT, false);
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id34d6df97760a11c299092dff8edbdb7033bce1c
Gerrit-Change-Number: 12014
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 01 Dec 2018 03:41:17 +
Gerrit-HasComments: Yes
