[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" The fix for IMPALA-5929 introduced a bug that produced wrong results. This bug is detailed in IMPALA-7960. Reverting for now. This reverts commit 545163bb0a5c86aa02652d0557871f5b694a6c82. Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Reviewed-on: http://gerrit.cloudera.org:8080/12073 Reviewed-by: Zoram Thanga Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 3 files changed, 0 insertions(+), 100 deletions(-) Approvals: Zoram Thanga: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 12 Dec 2018 04:47:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1582/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 12 Dec 2018 01:19:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3553/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 12 Dec 2018 00:31:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 12 Dec 2018 00:25:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12073 Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" The fix for IMPALA-5929 introduced a bug that produced wrong results. This bug is detailed in IMPALA-7960. Reverting for now. This reverts commit 545163bb0a5c86aa02652d0557871f5b694a6c82. Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 3 files changed, 0 insertions(+), 100 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/12073/1 -- To view, visit http://gerrit.cloudera.org:8080/12073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c Gerrit-Change-Number: 12073 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
