[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. This work was done by Sharanitha Harish. This commit adds support to display the metric last-synced-event-id as /metrics#events page whereas previously it was displayed only on the /events page. Testing: Added tests toMetaStoreEventsProcessorTest to verify: 1. If the metric updated as it should when new events were processed. 2. If the metric was not set when the event processor was not active. Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Reviewed-on: http://gerrit.cloudera.org:8080/14200 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/util/event-metrics.cc M be/src/util/event-metrics.h M common/thrift/JniCatalog.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 6 files changed, 33 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 14 Sep 2019 02:19:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 13 Sep 2019 22:09:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4948/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 13 Sep 2019 22:09:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 13 Sep 2019 22:08:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4510/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Sep 2019 23:04:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 1: Re-uploaded the change as original user in not active anymore. -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Sep 2019 22:23:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14200 Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. This work was done by Sharanitha Harish. This commit adds support to display the metric last-synced-event-id as /metrics#events page whereas previously it was displayed only on the /events page. Testing: Added tests toMetaStoreEventsProcessorTest to verify: 1. If the metric updated as it should when new events were processed. 2. If the metric was not set when the event processor was not active. Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d --- M be/src/util/event-metrics.cc M be/src/util/event-metrics.h M common/thrift/JniCatalog.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 6 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/14200/1 -- To view, visit http://gerrit.cloudera.org:8080/14200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iadab4a6cd3ad3c6c1b7931747ac55cd58ce3bb3d Gerrit-Change-Number: 14200 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/13947 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Abandoned This was submitted as a draft and the original author is not active anymore. Abandoning. -- To view, visit http://gerrit.cloudera.org:8080/13947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib113a5b9458dcf483b183e927544a6c6d46e1af3 Gerrit-Change-Number: 13947 Gerrit-PatchSet: 4 Gerrit-Owner: Sharanitha Harish Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14159 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4425/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974 Gerrit-Change-Number: 14159 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 28 Aug 2019 21:54:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Anurag Mantripragada has abandoned this change. ( http://gerrit.cloudera.org:8080/14159 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Abandoned Duplicate -- To view, visit http://gerrit.cloudera.org:8080/14159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974 Gerrit-Change-Number: 14159 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14159 Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. This work was done by Sharanitha Harish. This commit adds support to display the metric last-synced-event-id as /metrics#events page whereas previously it was displayed only on the /events page. Testing: Added tests toMetaStoreEventsProcessorTest to verify: 1. If the metric updated as it should when new events were processed. 2. If the metric was not set when the event processor was not active. Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974 --- M be/src/util/event-metrics.cc M be/src/util/event-metrics.h M common/thrift/JniCatalog.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 6 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/14159/1 -- To view, visit http://gerrit.cloudera.org:8080/14159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974 Gerrit-Change-Number: 14159 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
