[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. IMPALA-8307 Use test -x to check for ntp-wait Running ntp-wait --help can return 0 or 1 depending on the output of ntpq. For example: $ sudo ntp-wait --help 2> /dev/null; echo $? 0 $ sudo killall ntpd $ sudo ntp-wait --help 2> /dev/null; echo $? 1 This commit instead tests whether ntp-wait exists and is executable to determine if it's installed. Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Reviewed-on: http://gerrit.cloudera.org:8080/12726 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M testdata/cluster/admin 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 27 Mar 2019 00:43:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3959/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 26 Mar 2019 20:15:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 15 Mar 2019 21:06:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 15 Mar 2019 20:28:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. IMPALA-8307 Use test -x to check for ntp-wait Running ntp-wait --help can return 0 or 1 depending on the output of ntpq. For example: $ sudo ntp-wait --help 2> /dev/null; echo $? 0 $ sudo killall ntpd $ sudo ntp-wait --help 2> /dev/null; echo $? 1 This commit instead tests whether ntp-wait exists and is executable to determine if it's installed. Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c --- M testdata/cluster/admin 1 file changed, 10 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12726/2 -- To view, visit http://gerrit.cloudera.org:8080/12726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c Gerrit-Change-Number: 12726 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
