[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 12: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 17 Apr 2019 05:30:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests
- Manually verified that no regression when starting Hive 3 with
  USE_CDP_HIVE=true

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Reviewed-on: http://gerrit.cloudera.org:8080/13002
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 13
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 11: Code-Review+1

Thanks for making the changes and testing that HMS3 comes up.


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:50:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 11:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2808/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 23:30:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 10:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2804/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 21:20:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4029/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 17 Apr 2019 00:15:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 11: Code-Review+2

Bump this to +2


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 17 Apr 2019 00:14:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 11: Code-Review+1

> Patch Set 10:
>
> Hi Fredy, was wondering if you were able to start minicluster which spins up 
> HMS3 using this build? Just wanted to make sure that we are not regressing 
> IMPALA-8345 until we have automated jobs running against hive-3

I tested starting the minicluster with Hive 3 and no problem so far. I updated 
the commit message.

Carry Joe's +1.


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:49:21 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests
- Manually verified that no regression when starting Hive 3 with
  USE_CDP_HIVE=true

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/11
--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/10
--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 10: Code-Review+1

(1 comment)

This looks fine to me. I can +2 once other reviewers have a chance to look.

http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py@420
PS10, Line 420: download_cdp_components
This is getting very similar to download_cdh_components. At some point, we 
should consider combining them.



--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 20:46:36 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
..


Patch Set 10:

This is ready for review.


--
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Austin Nobis 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 16 Apr 2019 20:38:54 +
Gerrit-HasComments: No