[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
David Knupp has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. IMPALA-8346: Don't create FE testcase files unless testing locally The same test data setup scripts get called when loading data for mini-cluster testing and testing against a real deployed cluster. Unfortunately, we're seeing more and more that not all set up steps apply equally in both situations. This patch avoids one such example. It skips the creation of TPCDS testcase files when the cluster under test is a remote deployed one. Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba --- M testdata/bin/create-load-data.sh 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/4 -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 20:29:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Code-Review+1 (1 comment) This makes sense to me. If there are not other comments, I will +2. http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG@14 PS4, Line 14: It skips the creation of TPCDS : testcase files when the cluster under test is a remote deployed one. Maybe add one line saying that the testcase files are used during the frontend tests, and the frontend tests don't work against remote deployed clusters. -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 20:34:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Hello Bharath Vissapragada, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12958 to look at the new patch set (#5). Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. IMPALA-8346: Don't create FE testcase files unless testing locally The same test data setup scripts get called when loading data for mini-cluster testing and testing against a real deployed cluster. Unfortunately, we're seeing more and more that not all set up steps apply equally in both situations. This patch avoids one such example. It skips the creation of TPCDS testcase files that are used by the FE java tests. These tests don't run against deployed clusters. Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba --- M testdata/bin/create-load-data.sh 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/5 -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12958/4//COMMIT_MSG@14 PS4, Line 14: It skips the creation of TPCDS : testcase files that are used by the FE java tests. These tests don't > Maybe add one line saying that the testcase files are used during the front Thanks Joe. Done. -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 22:05:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 22:14:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 22:50:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4018/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 12 Apr 2019 22:50:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. IMPALA-8346: Don't create FE testcase files unless testing locally The same test data setup scripts get called when loading data for mini-cluster testing and testing against a real deployed cluster. Unfortunately, we're seeing more and more that not all set up steps apply equally in both situations. This patch avoids one such example. It skips the creation of TPCDS testcase files that are used by the FE java tests. These tests don't run against deployed clusters. Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Reviewed-on: http://gerrit.cloudera.org:8080/12958 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/bin/create-load-data.sh 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 7 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba Gerrit-Change-Number: 12958 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 13 Apr 2019 03:48:07 + Gerrit-HasComments: No
