[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing 
locally
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2742/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:24:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12958 )

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing 
locally
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2741/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:18:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread David Knupp (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12958

to look at the new patch set (#3).

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing 
locally
..

IMPALA-8346: Don't create FE testcase files unless tetsing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files when the cluster under test is a remote deployed one.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/3
--
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread David Knupp (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12958

to look at the new patch set (#2).

Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing 
locally
..

IMPALA-8346: Don't create FE testcase files unless tetsing locally

The same test data setup scripts get called when loading data for
mini-cluster testing and testing against a real deployed cluster.
Unfortunately, we're seeing more and more that not all set up steps
apply equally in both situations.

This patch avoids one such example. It skips the creation of TPCDS
testcase files when the cluster under test is a remote deployed one.

Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
---
M testdata/bin/create-load-data.sh
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12958/2
--
To view, visit http://gerrit.cloudera.org:8080/12958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe11d7cb50d9e2657152c94f8defcbc69ca7e1ba
Gerrit-Change-Number: 12958
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Impala Public Jenkins