[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. IMPALA-8392: fix parallel docker_images build I made the other targets depend on targets, not the timestamp file, according to the suggested solution in: https://gitlab.kitware.com/cmake/cmake/issues/17585 Testing: Ran "make -j 8 docker_images" locally, which now succeeds. Running dockerised tests. Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Reviewed-on: http://gerrit.cloudera.org:8080/13053 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/jenkins/dockerized-impala-run-tests.sh M docker/CMakeLists.txt 2 files changed, 11 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 17 Apr 2019 22:16:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 17 Apr 2019 17:13:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 17 Apr 2019 17:20:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4035/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 17 Apr 2019 17:20:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: The dockerised build succeeded with this change - https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/55/ -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 17 Apr 2019 16:56:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 17 Apr 2019 10:33:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. IMPALA-8392: fix parallel docker_images build I made the other targets depend on targets, not the timestamp file, according to the suggested solution in: https://gitlab.kitware.com/cmake/cmake/issues/17585 Testing: Ran "make -j 8 docker_images" locally, which now succeeds. Running dockerised tests. Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce --- M bin/jenkins/dockerized-impala-run-tests.sh M docker/CMakeLists.txt 2 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/13053/2 -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4031/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb658ee156eb9b186ff3fcc3e4a40ad87ed7c0ce Gerrit-Change-Number: 13053 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 17 Apr 2019 05:37:46 + Gerrit-HasComments: No
