[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 18 May 2019 01:24:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. IMPALA-8563: Update SSL ciphers used in BE tests Impala BE tests used RC4-based ciphers in a few BE tests, where OpenSSL contexts were set up manually. Since OpenSSL v1.1.0 these ciphers are not considered strong enough any more, so they are rejected, which made these tests fail on platforms using OpenSSL 1.1.0 (or higher), e.g. on Ubuntu 18.04. This patch changes the affected tests to use AES128 and AES256. The updated tests were verified on the following platforms: - Ubuntu 14.04, 16.04, 18.04 - CentOS 6.4, 7.4 Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Reviewed-on: http://gerrit.cloudera.org:8080/13364 Reviewed-by: Tim Armstrong Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M be/src/rpc/rpc-mgr-test.h M be/src/rpc/thrift-server-test.cc M be/src/util/webserver-test.cc 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Michael Ho: Looks good to me, but someone else must approve Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Code-Review+1 Thanks for fixing it. -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 17 May 2019 20:44:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13364/1/be/src/rpc/rpc-mgr-test.h File be/src/rpc/rpc-mgr-test.h: http://gerrit.cloudera.org:8080/#/c/13364/1/be/src/rpc/rpc-mgr-test.h@109 PS1, Line 109: // Only use TLSv1.0 compatible ciphers, as tests might run on machines with only TLSv1.0 I checked that the new ciphers were compatible with TLS1.0: https://www.openssl.org/docs/man1.1.0/man1/ciphers.html -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 17 May 2019 20:13:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4278/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 17 May 2019 20:13:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3268/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 17 May 2019 19:17:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests
Hello Michael Ho, Lars Volker, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13364 to review the following change. Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. IMPALA-8563: Update SSL ciphers used in BE tests Impala BE tests used RC4-based ciphers in a few BE tests, where OpenSSL contexts were set up manually. Since OpenSSL v1.1.0 these ciphers are not considered strong enough any more, so they are rejected, which made these tests fail on platforms using OpenSSL 1.1.0 (or higher), e.g. on Ubuntu 18.04. This patch changes the affected tests to use AES128 and AES256. The updated tests were verified on the following platforms: - Ubuntu 14.04, 16.04, 18.04 - CentOS 6.4, 7.4 Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca --- M be/src/rpc/rpc-mgr-test.h M be/src/rpc/thrift-server-test.cc M be/src/util/webserver-test.cc 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/13364/1 -- To view, visit http://gerrit.cloudera.org:8080/13364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I12b014361fb90afe63aed4b4608f6d6031e49cca Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
