[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 22:49:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC test runs IMPALA-7290 added a timezone query option check to this test but the expected order of query options being printed in the query profile was wrong specifically for an option expected in a test run with erasure coding turned on. This patch just puts them in the right order in the expected string. Testing: Tested on EC build. Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Reviewed-on: http://gerrit.cloudera.org:8080/13709 Reviewed-by: Bikramjeet Vig Tested-by: Impala Public Jenkins --- M tests/query_test/test_observability.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Bikramjeet Vig: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4538/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 17:12:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Code-Review+2 rebasing to fetch IMPALA-8700 that broke the previous GVO. Carrying forwards +2 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 17:11:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4526/ -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 22:58:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4526/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 16:46:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 3: Code-Review+2 Fixed a typo in the commit message. Carrying forward Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 16:46:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13709 to look at the new patch set (#3). Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC test runs IMPALA-7290 added a timezone query option check to this test but the expected order of query options being printed in the query profile was wrong specifically for an option expected in a test run with erasure coding turned on. This patch just puts them in the right order in the expected string. Testing: Tested on EC build. Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 --- M tests/query_test/test_observability.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/13709/3 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 22 Jun 2019 05:23:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3714/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 22 Jun 2019 02:06:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13709 to look at the new patch set (#2). Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC test runs IMPALA-7290 added a timezone query option check to this test but the expected order of query options being printed in the query profile was wrong specifically for an option expected in a test run with erasure coding turned on. This patch just puts them in the right order in the expected string. Testing: Testes on EC build. Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 --- M tests/query_test/test_observability.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/13709/2 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13709 Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC test runs IMPALA-7290 added a timezone query option check to this test but the expected order of query options being printed in the query profile was wrong specifically for an option expected in an test run with erasure coding turned on. This patch just puts them in the right order in the expected string. Testing: Testes on EC build. Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 --- M tests/query_test/test_observability.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/13709/1 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
