[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13965 Change subject: IMPALA-8771 Missing stats warning for complex type columns .. IMPALA-8771 Missing stats warning for complex type columns An extra condition is added to the table stats checking, so that the complex type columns are skipped and can not trigger missing stats warning. Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java A testdata/workloads/functional-query/queries/QueryTest/compute-stats-complextype-warning.test M testdata/workloads/functional-query/queries/QueryTest/show-stats.test M tests/metadata/test_compute_stats.py 4 files changed, 33 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13965/2 -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13965/2/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/13965/2/tests/metadata/test_compute_stats.py@86 PS2, Line 86: a flake8: E501 line too long (94 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Jul 2019 14:27:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13965 to look at the new patch set (#3). Change subject: IMPALA-8771 Missing stats warning for complex type columns .. IMPALA-8771 Missing stats warning for complex type columns An extra condition is added to the table stats checking, so that the complex type columns are skipped and can not trigger missing stats warning. Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java A testdata/workloads/functional-query/queries/QueryTest/compute-stats-complextype-warning.test M testdata/workloads/functional-query/queries/QueryTest/show-stats.test M tests/metadata/test_compute_stats.py 4 files changed, 34 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13965/3 -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4098/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Jul 2019 15:08:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4099/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Jul 2019 15:20:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4714/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Aug 2019 10:19:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4714/ -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Aug 2019 11:54:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4724/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 04 Aug 2019 14:37:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 3: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4724/ -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 04 Aug 2019 16:09:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4725/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 04 Aug 2019 16:45:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4725/ -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 04 Aug 2019 23:20:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13965 to look at the new patch set (#5). Change subject: IMPALA-8771 Missing stats warning for complex type columns .. IMPALA-8771 Missing stats warning for complex type columns An extra condition is added to the table stats checking, so that the complex type columns are skipped and can not trigger missing stats warning. Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java A testdata/workloads/functional-query/queries/QueryTest/compute-stats-complextype-warning.test M testdata/workloads/functional-query/queries/QueryTest/show-stats.test M tests/metadata/test_compute_stats.py 4 files changed, 32 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13965/5 -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4728/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Aug 2019 15:29:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 5: The previous test had a side effect that modified the 'functional.allcomplextypes' table properties which caused 'TestShowCreateTable' test failures. This patch creates a simple table with a complex type and tests the WARNING on that. -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Aug 2019 15:39:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4134/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Aug 2019 16:09:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4728/ -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Aug 2019 20:16:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771 Missing stats warning for complex type columns
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771 Missing stats warning for complex type columns .. Patch Set 5: Looks like this failed because there was a planner test that had the warning embedded in it: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/6952/testReport/junit/org.apache.impala.planner/PlannerTest/testResourceRequirementsWithHDFSNumRowsEstDisabled/ Otherwise looks good so I can +2 and start the merge once that test is update, thanks for fixing this source of confusion. -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 06 Aug 2019 06:00:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8771: Missing stats warning for complex type columns
Tim Armstrong has uploaded a new patch set (#8) to the change originally created by Tamas Mate. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771: Missing stats warning for complex type columns .. IMPALA-8771: Missing stats warning for complex type columns An extra condition is added to the table stats checking, so that the complex type columns are skipped and can not trigger missing stats warning. Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test A testdata/workloads/functional-query/queries/QueryTest/compute-stats-complextype-warning.test M testdata/workloads/functional-query/queries/QueryTest/show-stats.test M tests/metadata/test_compute_stats.py 5 files changed, 32 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13965/8 -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 8 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8771: Missing stats warning for complex type columns
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771: Missing stats warning for complex type columns .. IMPALA-8771: Missing stats warning for complex type columns An extra condition is added to the table stats checking, so that the complex type columns are skipped and can not trigger missing stats warning. Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Reviewed-on: http://gerrit.cloudera.org:8080/13965 Reviewed-by: Tim Armstrong Tested-by: Tim Armstrong --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test A testdata/workloads/functional-query/queries/QueryTest/compute-stats-complextype-warning.test M testdata/workloads/functional-query/queries/QueryTest/show-stats.test M tests/metadata/test_compute_stats.py 5 files changed, 32 insertions(+), 27 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 9 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8771: Missing stats warning for complex type columns
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13965 ) Change subject: IMPALA-8771: Missing stats warning for complex type columns .. Patch Set 8: Verified+1 Code-Review+2 Carry +2 and verified across rebase -- To view, visit http://gerrit.cloudera.org:8080/13965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b5c14da0c7f6eab373d80b2dbf7c974b2eb567 Gerrit-Change-Number: 13965 Gerrit-PatchSet: 8 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 06 Aug 2019 16:38:05 + Gerrit-HasComments: No
