[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13945 )

Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..

IMPALA-8802: Switch to pgrep for graceful shutdown helper

Some places discourage the use of pidof and favor pgrep instead. This
change switches usage to the latter in the graceful shutdown helper
introduced in IMPALA-8798.

Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Reviewed-on: http://gerrit.cloudera.org:8080/13945
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins 
---
M bin/graceful_shutdown_backends.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13945 )

Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 29 Jul 2019 23:33:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13945 )

Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4062/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 29 Jul 2019 17:18:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13945 )

Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4679/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 29 Jul 2019 16:51:41 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13945 )

Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 29 Jul 2019 16:42:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8802: Switch to pgrep for graceful shutdown helper

2019-07-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13945


Change subject: IMPALA-8802: Switch to pgrep for graceful shutdown helper
..

IMPALA-8802: Switch to pgrep for graceful shutdown helper

Some places discourage the use of pidof and favor pgrep instead. This
change switches usage to the latter in the graceful shutdown helper
introduced in IMPALA-8798.

Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
---
M bin/graceful_shutdown_backends.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/13945/1
--
To view, visit http://gerrit.cloudera.org:8080/13945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa8cc7112002a98c42b4dcfbe30b99ae0cfadf83
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker