[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-23 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..

]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Reviewed-on: http://gerrit.cloudera.org:8080/14249
Tested-by: Impala Public Jenkins 
Reviewed-by: Norbert Luksa 
Reviewed-by: Zoltan Borok-Nagy 
---
M docs/topics/impala_string_functions.xml
1 file changed, 276 insertions(+), 95 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Norbert Luksa: Looks good to me, but someone else must approve
  Zoltan Borok-Nagy: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Mon, 23 Sep 2019 11:14:20 +
Gerrit-HasComments: No


[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@833
PS3, Line 833:
> I updated the link to point to the older Wikipedia article you mentioned. O
Fair enough, just wanted to point out this.



--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sat, 21 Sep 2019 11:54:17 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 4: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/490/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 19 Sep 2019 17:03:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-19 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Norbert Luksa, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14249

to look at the new patch set (#4).

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..

]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
---
M docs/topics/impala_string_functions.xml
1 file changed, 276 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/14249/4
--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: ]IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/490/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 19 Sep 2019 16:51:31 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-19 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@130
PS3, Line 130: JARO_DISTANCE
> Shouldn't the short versions of these functions be displayed here? (JARO_DS
Done


http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@833
PS3, Line 833: boost_threshold
> Not sure, if it's something to point out, but boost_threshold for some reas
I updated the link to point to the older Wikipedia article you mentioned. 
Otherwise, I don't feel that it is necessary to mention the difference b/w 2 
versions of Wikipedia articles.



--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 19 Sep 2019 16:51:01 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-19 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@130
PS3, Line 130: JARO_DISTANCE
Shouldn't the short versions of these functions be displayed here? (JARO_DST, 
JARO_SIM, JW_DST, JW_SIM)


http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@833
PS3, Line 833: ps://en.wikiped
Not sure, if it's something to point out, but boost_threshold for some reasons 
is not mentioned in the current revision of the Wikipedia article. We followed 
an older version (linked below), since other reference implementations 
contained it, and was also requested by customers.
The difference in short is, that the current Wikipedia revision always applies 
the prefix weight, while our implementation only does over 0.7 Jaro-distance 
value.

https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/Jaro%E2%80%93Winkler_distance.html



--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 19 Sep 2019 07:42:09 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/489/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 18 Sep 2019 18:25:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Norbert Luksa, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14249

to look at the new patch set (#3).

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..

IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
---
M docs/topics/impala_string_functions.xml
1 file changed, 273 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/14249/3
--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/489/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 18 Sep 2019 17:59:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 2: Code-Review+1

Lgtm, I can give the final +2 once Norbert reviewed it.


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 18 Sep 2019 15:41:08 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/487/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:53:28 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/487/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:30:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Norbert Luksa, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14249

to look at the new patch set (#2).

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..

IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
---
M docs/topics/impala_string_functions.xml
1 file changed, 269 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/14249/2
--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14249/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14249/1/docs/topics/impala_string_functions.xml@792
PS1, Line 792: 256
> 256 or 255 (think max size is 255)
Done



--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:30:08 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14249/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14249/1/docs/topics/impala_string_functions.xml@792
PS1, Line 792: 256
256 or 255 (think max size is 255)
also check other similar references



--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:16:54 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/486/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Norbert Luksa 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 17 Sep 2019 22:54:03 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14249


Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..

IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
---
M docs/topics/impala_string_functions.xml
1 file changed, 244 insertions(+), 95 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/14249/1
--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 


[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14249 )

Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/486/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3
Gerrit-Change-Number: 14249
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 17 Sep 2019 22:31:02 +
Gerrit-HasComments: No