[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..

IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Reviewed-on: http://gerrit.cloudera.org:8080/14229
Reviewed-by: Bharath Vissapragada 
Tested-by: Impala Public Jenkins 
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
3 files changed, 54 insertions(+), 10 deletions(-)

Approvals:
  Bharath Vissapragada: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 4: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/483/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:19:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml@118
PS3, Line 118: Sentry
> update?
Done



--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:15:27 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/483/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:15:21 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14229

to look at the new patch set (#4).

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..

IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
3 files changed, 54 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/4
--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml@118
PS3, Line 118: Sentry
update?



--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:09:16 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/480/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:52:40 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml@113
PS2, Line 113: 
 :
 :   Sentry-Related Content
> What about these?
Done


http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml@180
PS2, Line 180: .
> Refer the jira?
Done



--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:50:04 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/480/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:46:11 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14229

to look at the new patch set (#3).

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..

IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
3 files changed, 50 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/3
--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/479/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:44:12 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 2:

(2 comments)

Couple of nits, lgtm otherwise.

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml@113
PS2, Line 113: 
 :
 :   Sentry-Related Content
What about these?


http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml@180
PS2, Line 180: .
Refer the jira?



--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:34:31 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/479/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:31:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14229

to look at the new patch set (#2).

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..

IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
3 files changed, 44 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/2
--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@123
PS1, Line 123:   
> This should be in Ranger integration section?
Done


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@128
PS1, Line 128: includes
> implies? (nit: extra space)
There is no extra space. Changed "includes" to "implies".


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@156
PS1, Line 156: ownership is enabled by default in Impala,
> I think this should be rephrased.
Done


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@162
PS1, Line 162: An owner has the OWNER privilege if enabled in
 : Sentry.
> remove.
Done


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@173
PS1, Line 173:   
> We should also mention the caveat with Ranger ownership integration that "S
Done



--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:31:13 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@123
PS1, Line 123:   
This should be in Ranger integration section?


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@128
PS1, Line 128: includes
implies? (nit: extra space)


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@156
PS1, Line 156: ownership is enabled by default in Impala,
I think this should be rephrased.

Object ownership for tables, views and databases is enabled by default in 
Impala. To define owner specific privileges, go to ranger UI and define 
appropriate policies on {OWNER} user


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@162
PS1, Line 162: An owner has the OWNER privilege if enabled in
 : Sentry.
remove.


http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@173
PS1, Line 173:   
We should also mention the caveat with Ranger ownership integration that "SHOW 
TABLES" may not work as expected.  I added it in the commit message [1]. TL;DR 
"show tables" command cannot infer ownership information because the current 
design of metadata lacks aggressive caching of ownership information. The user 
behavior ends up like, show tables does not list the table even though a user 
owns it unless it is fully loaded in the coordinator catalog cache IMPALA-8937. 
Users can still do queries on the table (like select * from foo) because these 
kinds of statements preload the table before performing the authz checks.

[1] 
https://github.com/apache/impala/commit/ced6e98fb4c361efa4bcc7e5441ccdb8debba8e9



-- 
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 16 Sep 2019 17:30:58 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/478/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Sat, 14 Sep 2019 02:41:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14229 )

Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/478/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Sat, 14 Sep 2019 02:28:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14229


Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated 
with Ranger
..

IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
2 files changed, 33 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/1
--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni