[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/501/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 23:34:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14340 Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. IMPALA-8988: [DOCS] DATE type is supported AVRO tables Change-Id: I95f37accddadcba436676498d5cbb34cda281846 --- M docs/topics/impala_avro.xml M docs/topics/impala_date.xml 2 files changed, 97 insertions(+), 55 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14340/1 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/501/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 23:52:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml File docs/topics/impala_date.xml: http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml@53 PS1, Line 53: -01-01 Note that we are in the midst of changing the valid range for DATE values to 0001-01-01 to -12-31,. We are changing the lower end of the valid range from year 0 to year 1 to comply with the ANSI SQL standard. http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml@69 PS1, Line 69: Parquet uses DATE logical type for dates. The : DATE logical type annotates an INT32 : that stores the number of days from the Unix epoch, January 1, 1970. This : representation introduces a Parquet interoperability issue between Impala : and older versions of Hive: : : If Hive versions lower than 3.1 wrote dates earlier than 1582-10-15 to a : Parquet table, those dates would be read back incorrectly by Impala and : vice versa. In Hive 3.1 and higher, this is no longer an issue. Avro has the same issue since avro too stores DATE logical type as a number of days since epoch. -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 13:46:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml File docs/topics/impala_date.xml: http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml@53 PS1, Line 53: -01-01 > Note that we are in the midst of changing the valid range for DATE values t I will update this now, assuming that patch will be approved. http://gerrit.cloudera.org:8080/#/c/14340/1/docs/topics/impala_date.xml@69 PS1, Line 69: Parquet uses DATE logical type for dates. The : DATE logical type annotates an INT32 : that stores the number of days from the Unix epoch, January 1, 1970. This : representation introduces a Parquet interoperability issue between Impala : and older versions of Hive: : : If Hive versions lower than 3.1 wrote dates earlier than 1582-10-15 to a : Parquet table, those dates would be read back incorrectly by Impala and : vice versa. In Hive 3.1 and higher, this is no longer an issue. > Avro has the same issue since avro too stores DATE logical type as a number Done -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 18:33:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14340 to look at the new patch set (#2). Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. IMPALA-8988: [DOCS] DATE type is supported AVRO tables Change-Id: I95f37accddadcba436676498d5cbb34cda281846 --- M docs/topics/impala_avro.xml M docs/topics/impala_date.xml 2 files changed, 102 insertions(+), 62 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14340/2 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/502/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 18:34:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/502/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 18:54:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Oct 2019 11:26:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14340 to look at the new patch set (#3). Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. IMPALA-8988: [DOCS] DATE type is supported AVRO tables Change-Id: I95f37accddadcba436676498d5cbb34cda281846 --- M docs/topics/impala_avro.xml M docs/topics/impala_date.xml 2 files changed, 102 insertions(+), 62 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14340/3 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/503/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Oct 2019 18:05:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 3: A typo fix -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Oct 2019 18:05:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/503/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Oct 2019 18:40:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. IMPALA-8988: [DOCS] DATE type is supported AVRO tables Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Reviewed-on: http://gerrit.cloudera.org:8080/14340 Tested-by: Impala Public Jenkins Reviewed-by: Alex Rodoni --- M docs/topics/impala_avro.xml M docs/topics/impala_date.xml 2 files changed, 102 insertions(+), 62 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Rodoni: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Oct 2019 18:43:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 4: Sahil and Joe, I addressed all the comments, and have one remaining question in the google doc. Please take a look and let me know if I can move this along. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 07 Nov 2019 22:52:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 4: Verified+1 > Sahil and Joe, > I addressed all the comments, and have one remaining question in > the google doc. Please take a look and let me know if I can move > this along. > Thanks! -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 07 Nov 2019 22:54:28 + Gerrit-HasComments: No
