[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 04 Oct 2019 21:05:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' When SPNEGO was first implemented for both hs2 and the webui, the way we handled requests that did not include an "Authorization" header was to pass an empty string to gss-api and then return a "WWW-Authenticate: Negotiate " where was whatever was returned by gss-api. This works with some clients, but appears to fail with others. This patch modifies the behavior to not send the with the initial WWW-Authenticate, which works with all tested clients. Testing: - Tested with curl, Knox, and Java's HttpURLConnection API. Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Reviewed-on: http://gerrit.cloudera.org:8080/14352 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/rpc/authentication.cc M be/src/util/webserver.cc 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 1: Code-Review+2 I suppose adding a test for this with the ApacheDS KDC and HttpUrlConnection is too complicated? If so, that's fine. -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 04 Oct 2019 16:25:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 04 Oct 2019 16:47:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5054/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 04 Oct 2019 16:47:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4705/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 02 Oct 2019 23:59:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14352 Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' When SPNEGO was first implemented for both hs2 and the webui, the way we handled requests that did not include an "Authorization" header was to pass an empty string to gss-api and then return a "WWW-Authenticate: Negotiate " where was whatever was returned by gss-api. This works with some clients, but appears to fail with others. This patch modifies the behavior to not send the with the initial WWW-Authenticate, which works with all tested clients. Testing: - Tested with curl, Knox, and Java's HttpURLConnection API. Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd --- M be/src/rpc/authentication.cc M be/src/util/webserver.cc 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/14352/1 -- To view, visit http://gerrit.cloudera.org:8080/14352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id9b6ac99b799324ec22e95fd1eb022d5ad6f54bd Gerrit-Change-Number: 14352 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
