[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 03 Apr 2019 03:47:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Improve error handling for validation of unified backend executable bin/validate-unified-backend-test-filters.py currently does not handle the case where the call to run the unified backend test executable fails. Instead, it produces a very confusing message about invalid filters that does not mention that the execution failed. This checks the return code when running the unified backend test executable and produces a reasonable message if the return code is not 0. Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Reviewed-on: http://gerrit.cloudera.org:8080/12895 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/validate-unified-backend-test-filters.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3972/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 02 Apr 2019 22:47:08 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 02 Apr 2019 22:47:07 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 01 Apr 2019 21:32:41 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 01 Apr 2019 16:14:20 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve error handling for validation of unified backend executable
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12895 Change subject: Improve error handling for validation of unified backend executable .. Improve error handling for validation of unified backend executable bin/validate-unified-backend-test-filters.py currently does not handle the case where the call to run the unified backend test executable fails. Instead, it produces a very confusing message about invalid filters that does not mention that the execution failed. This checks the return code when running the unified backend test executable and produces a reasonable message if the return code is not 0. Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 --- M bin/validate-unified-backend-test-filters.py 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/12895/1 -- To view, visit http://gerrit.cloudera.org:8080/12895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia84cd074be79bc9d99b0621a1ae216f3debf5833 Gerrit-Change-Number: 12895 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
