[Impala-ASF-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10994 ) Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined .. KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag", added the use of the rpc flag SO_REUSEREPORT. This flag is not available with older versions of Linux, resulting in a compiler error. This patch avoids the compiler error with a macro that checks if SO_REUSEPORT is defined, and if it's not attempting to set it will return an error. -- IMPALA-7302: This is cherry-picked to fix builds breaking on CentOS 6.4. Since some of our Jenkins machines are CentOS 6.4, and upgrading them to our new minimum supported OS of CentOS 6.8 is non-trivial, we cherry- pick this patch to temporarily unblock these builds until the Jenkins AMIs are upgraded. Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 Reviewed-on: http://gerrit.cloudera.org:8080/10994 Reviewed-by: Thomas Marshall Tested-by: Impala Public Jenkins --- M be/src/kudu/util/net/socket.cc 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Thomas Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 Gerrit-Change-Number: 10994 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10994 ) Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 Gerrit-Change-Number: 10994 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 20 Jul 2018 01:59:22 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10994 ) Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2843/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 Gerrit-Change-Number: 10994 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Thu, 19 Jul 2018 22:39:31 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10994 Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined .. KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag", added the use of the rpc flag SO_REUSEREPORT. This flag is not available with older versions of Linux, resulting in a compiler error. This patch avoids the compiler error with a macro that checks if SO_REUSEPORT is defined, and if it's not attempting to set it will return an error. -- IMPALA-7302: This is cherry-picked to fix builds breaking on CentOS 6.4. Since some of our Jenkins machines are CentOS 6.4, and upgrading them to our new minimum supported OS of CentOS 6.8 is non-trivial, we cherry- pick this patch to temporarily unblock these builds until the Jenkins AMIs are upgraded. Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 --- M be/src/kudu/util/net/socket.cc 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/10994/1 -- To view, visit http://gerrit.cloudera.org:8080/10994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I042125cdaedafa5ebbc09e5a3c12112dfeec59a1 Gerrit-Change-Number: 10994 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Thomas Marshall
