[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 04:32:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Only fetch needed branches in compare_branches.py Fetching all branches of a remote repo will be time-consuming. This changes compare_branches.py to only fetch the needed branches, i.e. source_branch and target_branch. Tests: - Before this change, it can't finish in 30 mins when comparing two downstream branches. After this change, it finishes in one minute. Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Reviewed-on: http://gerrit.cloudera.org:8080/17246 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/compare_branches.py 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7036/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:30 + Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 20:52:41 + Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/8473/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 09:01:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17246 Change subject: Only fetch needed branches in compare_branches.py .. Only fetch needed branches in compare_branches.py Fetching all branches of a remote repo will be time-consuming. This changes compare_branches.py to only fetch the needed branches, i.e. source_branch and target_branch. Tests: - Before this change, it can't finish in 30 mins when comparing two downstream branches. After this change, it finishes in one minute. Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 --- M bin/compare_branches.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/17246/1 -- To view, visit http://gerrit.cloudera.org:8080/17246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7 Gerrit-Change-Number: 17246 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
