[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Remove "Could not transfer" exclusion in mvn-quiet.sh "Could not transfer" warning messages are noisy. However, excluding "Could not transfer" words can lead to actual error messages that contain "Could not transfer" to not be shown in the stdout, which can make debugging difficult. This patch updates mvn-quiet.sh to show "Could not transfer" messages. Testing: - Ran FE build Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Reviewed-on: http://gerrit.cloudera.org:8080/13647 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/mvn-quiet.sh 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 14 Jun 2019 21:50:17 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: > Patch Set 1: > > We could also consider removing the whole error suppression thing. I added it > a long time ago when I was trying to make Jenkins logs less noisy but I'm now > not sure that it was a good idea. The current mvn-quiet.sh doesn't suppress error though. So, I think we're good here. -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 14 Jun 2019 16:25:21 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4476/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 14 Jun 2019 16:25:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 14 Jun 2019 16:25:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: We could also consider removing the whole error suppression thing. I added it a long time ago when I was trying to make Jenkins logs less noisy but I'm now not sure that it was a good idea. -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 14 Jun 2019 15:29:13 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: Code-Review+2 Seems reasonable to me, especially if it is hiding genuine errors from stdout. -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 14 Jun 2019 15:02:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3627/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 14 Jun 2019 03:04:14 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13647 Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Remove "Could not transfer" exclusion in mvn-quiet.sh "Could not transfer" warning messages are noisy. However, excluding "Could not transfer" words can lead to actual error messages that contain "Could not transfer" to not be shown in the stdout, which can make debugging difficult. This patch updates mvn-quiet.sh to show "Could not transfer" messages. Testing: - Ran FE build Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d --- M bin/mvn-quiet.sh 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/13647/1 -- To view, visit http://gerrit.cloudera.org:8080/13647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide3367fd98abbbe11eec1fa86fbad8b32eeecb8d Gerrit-Change-Number: 13647 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
