[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..

Removing (broken) retries from split-hbase.sh.

The retries in split-hbase.sh don't work in the common case,
because $MINIKDC_PRINC_HIVE is not set in non-kerberized (common)
environments. The regular data load scripts (create-load-data.sh)
have code to manage that, but split-hbase.sh blindly forges ahead,
leading to errors like:

  /home/impdev/Impala/testdata/bin/split-hbase.sh: line 49: MINIKDC_PRINC_HIVE: 
unbound variable
  Error in /home/impdev/Impala/testdata/bin/create-load-data.sh at line 48: 
LOAD_DATA_ARGS=""

Since this hasn't been working, I opted to remove it entirely, as a failure on
the line where HBase splitting actually failed would be significantly more
useful than the error here. A search of mailing lists suggested that I was at
least the second person to have run into this. (In my case, I did break HBase
splitting, but it took me a second to identify the error, since the log was
spammed with unrelated information relating to the cluster restart.)

Testing: core tests.

Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Reviewed-on: http://gerrit.cloudera.org:8080/9588
Reviewed-by: Philip Zeyliger 
Tested-by: Impala Public Jenkins
---
M testdata/bin/split-hbase.sh
1 file changed, 3 insertions(+), 14 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 15 Mar 2018 01:32:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2097/


--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 14 Mar 2018 21:49:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..


Patch Set 2: Code-Review+2

Carry +2 after rebase.


--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 14 Mar 2018 21:49:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..


Patch Set 1: Code-Review+2

Thanks for fixing this.


--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 14 Mar 2018 21:39:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9588 )

Change subject: Removing (broken) retries from split-hbase.sh.
..


Patch Set 1:

https://jenkins.impala.io/job/gerrit-verify-dryrun-external/92/ passed with 
this change.


--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 13 Mar 2018 04:57:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9588


Change subject: Removing (broken) retries from split-hbase.sh.
..

Removing (broken) retries from split-hbase.sh.

The retries in split-hbase.sh don't work in the common case,
because $MINIKDC_PRINC_HIVE is not set in non-kerberized (common)
environments. The regular data load scripts (create-load-data.sh)
have code to manage that, but split-hbase.sh blindly forges ahead,
leading to errors like:

  /home/impdev/Impala/testdata/bin/split-hbase.sh: line 49: MINIKDC_PRINC_HIVE: 
unbound variable
  Error in /home/impdev/Impala/testdata/bin/create-load-data.sh at line 48: 
LOAD_DATA_ARGS=""

Since this hasn't been working, I opted to remove it entirely, as a failure on
the line where HBase splitting actually failed would be significantly more
useful than the error here. A search of mailing lists suggested that I was at
least the second person to have run into this. (In my case, I did break HBase
splitting, but it took me a second to identify the error, since the log was
spammed with unrelated information relating to the cluster restart.)

Testing: core tests.

Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
---
M testdata/bin/split-hbase.sh
1 file changed, 3 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/9588/1
--
To view, visit http://gerrit.cloudera.org:8080/9588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I715891c9e744f21002330c3ae3ebc14095d94ffd
Gerrit-Change-Number: 9588
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger