[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/12271/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:30:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..

Revert "IMPALA-11865: Set thread names for Java thread pools"

This reverts commit 41117e649049b3490639851c611d9d6a044c64c2.

Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Reviewed-on: http://gerrit.cloudera.org:8080/19462
Reviewed-by: Michael Smith 
Reviewed-by: Joe McDonnell 
Tested-by: Joe McDonnell 
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M 
fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java
M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
5 files changed, 9 insertions(+), 27 deletions(-)

Approvals:
  Michael Smith: Looks good to me, approved
  Joe McDonnell: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:12:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:12:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..


Patch Set 1:

We noticed some minor issues in the original patch at 
https://gerrit.cloudera.org/#/c/19458/. Let's go ahead and revert, then take 
some time to get it right.


--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:11:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/19462

to review the following change.


Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..

Revert "IMPALA-11865: Set thread names for Java thread pools"

This reverts commit 41117e649049b3490639851c611d9d6a044c64c2.

Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M 
fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java
M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
5 files changed, 9 insertions(+), 27 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/19462/1
--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has created a revert of this change. ( 
http://gerrit.cloudera.org:8080/19462 )

Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools"
..


Uploaded patch set 1.
--
To view, visit http://gerrit.cloudera.org:8080/19462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: revert
Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124
Gerrit-Change-Number: 19462
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith