[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when using LibCache." This reverts commit 4aafa5e9ba9fe22d2dbc7764a796b3cd04136cc0. See IMPALA-6488 for an example of a crash that this revert is trying to avoid. Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Reviewed-on: http://gerrit.cloudera.org:8080/9244 Reviewed-by: Alex BehmReviewed-by: Tim Armstrong Reviewed-by: Vuk Ercegovac Tested-by: Thomas Tauber-Marshall --- M be/src/codegen/llvm-codegen.cc M be/src/exec/external-data-source-executor.cc M be/src/exprs/hive-udf-call.cc M be/src/exprs/hive-udf-call.h M be/src/runtime/lib-cache.cc M be/src/runtime/lib-cache.h M be/src/service/fe-support.cc M tests/query_test/test_udfs.py 8 files changed, 53 insertions(+), 172 deletions(-) Approvals: Alex Behm: Looks good to me, approved Tim Armstrong: Looks good to me, approved Vuk Ercegovac: Looks good to me, but someone else must approve Thomas Tauber-Marshall: Verified -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk ErcegovacGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 07 Feb 2018 20:54:35 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk ErcegovacGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 07 Feb 2018 20:02:50 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk ErcegovacGerrit-Reviewer: Alex Behm Gerrit-Comment-Date: Wed, 07 Feb 2018 19:43:01 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk ErcegovacGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 07 Feb 2018 19:43:07 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9244 Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when using LibCache." This reverts commit 4aafa5e9ba9fe22d2dbc7764a796b3cd04136cc0. See IMPALA-6488 for an example of a crash that this revert is trying to avoid. Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f --- M be/src/codegen/llvm-codegen.cc M be/src/exec/external-data-source-executor.cc M be/src/exprs/hive-udf-call.cc M be/src/exprs/hive-udf-call.h M be/src/runtime/lib-cache.cc M be/src/runtime/lib-cache.h M be/src/service/fe-support.cc M tests/query_test/test_udfs.py 8 files changed, 53 insertions(+), 172 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/9244/1 -- To view, visit http://gerrit.cloudera.org:8080/9244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f Gerrit-Change-Number: 9244 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac