[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-10-25 Thread Joe McDonnell (Code Review) 
Joe McDonnell has abandoned this change. ( 
http://gerrit.cloudera.org:8080/19885 )

Change subject: Specify the native toolchain revision exactly
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/19885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
Gerrit-Change-Number: 19885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith

[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-08-18 Thread Michael Smith (Code Review) 
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19885 )

Change subject: Specify the native toolchain revision exactly
..


Patch Set 2:

https://gerrit.cloudera.org/c/20267/ now incorporates this change.


--
To view, visit http://gerrit.cloudera.org:8080/19885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
Gerrit-Change-Number: 19885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Fri, 18 Aug 2023 21:14:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-08-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19885 )

Change subject: Specify the native toolchain revision exactly
..


Patch Set 2:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/13754/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/19885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
Gerrit-Change-Number: 19885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 15 Aug 2023 19:39:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-08-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19885 )

Change subject: Specify the native toolchain revision exactly
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19885/2/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/19885/2/bin/impala-config.sh@85
PS2, Line 85: export 
IMPALA_TOOLCHAIN_REPO=${IMPALA_TOOLCHAIN_REPO:-https://github.com/cloudera/native-toolchain.git}
line too long (103 > 90)


http://gerrit.cloudera.org:8080/#/c/19885/2/bin/impala-config.sh@87
PS2, Line 87: export 
IMPALA_TOOLCHAIN_COMMIT_HASH=${IMPALA_TOOLCHAIN_COMMIT_HASH-93f89038db8314fd8b136266682ab8fc59367944}
line too long (108 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/19885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
Gerrit-Change-Number: 19885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 15 Aug 2023 19:17:00 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-08-15 Thread Joe McDonnell (Code Review) 
Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19885


Change subject: Specify the native toolchain revision exactly
..

Specify the native toolchain revision exactly

Adds IMPALA_TOOLCHAIN_REPO, IMPALA_TOOLCHAIN_BRANCH, and
IMPALA_TOOLCHAIN_COMMIT_HASH so everything is clear about
what toolchain is used for this Impala commit.

Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
---
M bin/bootstrap_system.sh
M bin/impala-config.sh
2 files changed, 13 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/19885/2
--
To view, visit http://gerrit.cloudera.org:8080/19885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1cb3476fb0c0fdc020782fd543abc3aaa2873a9
Gerrit-Change-Number: 19885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins