[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 This fixes some issues with regard to template variable scoping that will be useful for Knox integration. Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Reviewed-on: http://gerrit.cloudera.org:8080/13563 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/thirdparty/mustache/README M be/src/thirdparty/mustache/mustache.cc M be/src/thirdparty/mustache/mustache.h M be/src/util/webserver.cc 4 files changed, 184 insertions(+), 102 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 11 Jun 2019 23:24:59 + Gerrit-HasComments: No
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 11 Jun 2019 17:36:55 + Gerrit-HasComments: No
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4445/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 11 Jun 2019 17:36:56 + Gerrit-HasComments: No
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 1: Code-Review+2 I checked this out and clicked around the debug pages a bit to make sure everything looked normal -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 10 Jun 2019 20:15:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3546/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 07 Jun 2019 22:24:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13563/1/be/src/thirdparty/mustache/mustache.cc File be/src/thirdparty/mustache/mustache.cc: http://gerrit.cloudera.org:8080/#/c/13563/1/be/src/thirdparty/mustache/mustache.cc@153 PS1, Line 153: // the entity does not exist (i.e. the path is invalid), 'resolved' will be set to nullptr. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13563/1/be/src/thirdparty/mustache/mustache.cc@349 PS1, Line 349: int EvaluateLength(const string& document, const int idx, const ContextStack* context_stack, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13563/1/be/src/thirdparty/mustache/mustache.cc@363 PS1, Line 363: int EvaluateLiteral(const string& document, const int idx, const ContextStack* context_stack, line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 07 Jun 2019 21:44:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13563 Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 This fixes some issues with regard to template variable scoping that will be useful for Knox integration. Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed --- M be/src/thirdparty/mustache/README M be/src/thirdparty/mustache/mustache.cc M be/src/thirdparty/mustache/mustache.h M be/src/util/webserver.cc 4 files changed, 184 insertions(+), 102 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/13563/1 -- To view, visit http://gerrit.cloudera.org:8080/13563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If26f3aaa2a3279a1f6a300c4f4cee7ec899e22ed Gerrit-Change-Number: 13563 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon
