[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-09 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..

Update mvn snapshot dependencies in "clean" checkouts

buildall.sh saves the cdh/cdp version into .cdh/.cdp, and updates
the dependencies if this doesn't match the version from config.

This lead to updating the dependencies when switching to a different
checkout in the same directory, but didn't do this in a fresh checkout,
which could lead to build issues when the .m2 cache was dirty.

Note that this doesn't protect from switching between Impala directories
with different cdh/cdp versions.

Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Reviewed-on: http://gerrit.cloudera.org:8080/14854
Reviewed-by: Zoltan Borok-Nagy 
Tested-by: Impala Public Jenkins 
Reviewed-by: Laszlo Gaal 
---
M buildall.sh
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, but someone else must approve
  Impala Public Jenkins: Verified
  Laszlo Gaal: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Zoltan Borok-Nagy

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-08 Thread Laszlo Gaal (Code Review) 
Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1: Code-Review+2

LGTM; I'll keep an eye on the builds anyway.


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 08 Dec 2019 21:03:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sat, 07 Dec 2019 16:32:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5321/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sat, 07 Dec 2019 12:01:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5320/


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sat, 07 Dec 2019 00:52:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5320/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 06 Dec 2019 14:52:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-06 Thread Zoltan Borok-Nagy (Code Review) 
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 06 Dec 2019 14:10:32 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-05 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14854 )

Change subject: Update mvn snapshot dependencies in "clean" checkouts
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/5213/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 05 Dec 2019 19:56:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update mvn snapshot dependencies in "clean" checkouts

2019-12-05 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14854


Change subject: Update mvn snapshot dependencies in "clean" checkouts
..

Update mvn snapshot dependencies in "clean" checkouts

buildall.sh saves the cdh/cdp version into .cdh/.cdp, and updates
the dependencies if this doesn't match the version from config.

This lead to updating the dependencies when switching to a different
checkout in the same directory, but didn't do this in a fresh checkout,
which could lead to build issues when the .m2 cache was dirty.

Note that this doesn't protect from switching between Impala directories
with different cdh/cdp versions.

Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
---
M buildall.sh
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/14854/1
--
To view, visit http://gerrit.cloudera.org:8080/14854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bbde17e7c97466391aa20ac3d59c6943e7f7256
Gerrit-Change-Number: 14854
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer