[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Todd Lipcon (Code Review)]

Hello Michael Ho, Lars Volker,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/13768

to review the following change.


Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..

Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

This updates to the latest build of squeasel, which fixes a few small
issues and also improves support for keepalive. This patch doesn't
itself enable keepalive, but switches to the new APIs.

Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/thirdparty/squeasel/squeasel.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
4 files changed, 76 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/13768/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13768/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/13768/1/be/src/util/webserver.cc@393
PS1, Line 393: sq_callback_result_t 
Webserver::BeginRequestCallbackStatic(struct sq_connection* connection) {
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Fri, 28 Jun 2019 23:42:25 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3788/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Sat, 29 Jun 2019 00:22:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 1: Code-Review+2

Didn't look too much into the diff in squeasel files as they are mostly 
copy-and-paste from upstream I assume.

LGTM otherwise. Please fix the formatting nit in webserver.cc


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:09:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Todd Lipcon (Code Review)]

Hello Michael Ho, Lars Volker, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13768

to look at the new patch set (#2).

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..

Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

This updates to the latest build of squeasel, which fixes a few small
issues and also improves support for keepalive. This patch doesn't
itself enable keepalive, but switches to the new APIs.

Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/thirdparty/squeasel/squeasel.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
4 files changed, 77 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/13768/2
--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 3: Code-Review+2

ps2 fixes the whitespace, ps3 is just a rebase. Carrying +2


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:18:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4572/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:18:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3794/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:57:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..

Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

This updates to the latest build of squeasel, which fixes a few small
issues and also improves support for keepalive. This patch doesn't
itself enable keepalive, but switches to the new APIs.

Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Reviewed-on: http://gerrit.cloudera.org:8080/13768
Reviewed-by: Todd Lipcon 
Tested-by: Impala Public Jenkins 
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/thirdparty/squeasel/squeasel.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
4 files changed, 77 insertions(+), 31 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 02 Jul 2019 02:58:22 +
Gerrit-HasComments: No