[Impala-ASF-CR] test recover partitions.py had asserts that were always true.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10993 ) Change subject: test_recover_partitions.py had asserts that were always true. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Gerrit-Change-Number: 10993 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 20:35:30 + Gerrit-HasComments: No
[Impala-ASF-CR] test recover partitions.py had asserts that were always true.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10993 ) Change subject: test_recover_partitions.py had asserts that were always true. .. test_recover_partitions.py had asserts that were always true. Running "python -m compileall" discovered some assertions that were always true. I've re-instated them to their true spirit. Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Reviewed-on: http://gerrit.cloudera.org:8080/10993 Reviewed-by: Vuk Ercegovac Tested-by: Impala Public Jenkins --- M tests/metadata/test_recover_partitions.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Gerrit-Change-Number: 10993 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] test recover partitions.py had asserts that were always true.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10993 ) Change subject: test_recover_partitions.py had asserts that were always true. .. Patch Set 1: Code-Review+2 there was a sweep of this not long ago. thanks for fixing the missing ones. -- To view, visit http://gerrit.cloudera.org:8080/10993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Gerrit-Change-Number: 10993 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 19 Jul 2018 17:27:03 + Gerrit-HasComments: No
[Impala-ASF-CR] test recover partitions.py had asserts that were always true.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10993 ) Change subject: test_recover_partitions.py had asserts that were always true. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2842/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Gerrit-Change-Number: 10993 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 19 Jul 2018 17:17:03 + Gerrit-HasComments: No
