[native-toolchain-CR] Add documentation for docker-based toolchain builds
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Add documentation for docker-based toolchain builds This commit adds basic documentation with regard to docker-based toolchain builds. It briefly outlines how to build images and how to use them to build the toolchain. I also added the ability to fetch images from a docker registry. And fixed an 'undefined' variable problem with docker-based builds. Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Reviewed-on: http://gerrit.cloudera.org:8080/12810 Reviewed-by: Thomas Marshall Tested-by: Thomas Marshall --- M Makefile A docker/README.md M functions.sh 3 files changed, 52 insertions(+), 5 deletions(-) Approvals: Thomas Marshall: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Gerrit-Change-Number: 12810 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Gerrit-Change-Number: 12810 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 25 Mar 2019 17:22:36 + Gerrit-HasComments: No
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Gerrit-Change-Number: 12810 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Thu, 21 Mar 2019 20:19:20 + Gerrit-HasComments: No
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Hello Thomas Marshall, Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12810 to look at the new patch set (#2). Change subject: Add documentation for docker-based toolchain builds .. Add documentation for docker-based toolchain builds This commit adds basic documentation with regard to docker-based toolchain builds. It briefly outlines how to build images and how to use them to build the toolchain. I also added the ability to fetch images from a docker registry. And fixed an 'undefined' variable problem with docker-based builds. Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 --- M Makefile A docker/README.md M functions.sh 3 files changed, 52 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/12810/2 -- To view, visit http://gerrit.cloudera.org:8080/12810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Gerrit-Change-Number: 12810 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall
