[native-toolchain-CR] Add documentation for docker-related toolchain builds

[Hector Acosta (Code Review)]

Hector Acosta has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12810


Change subject: Add documentation for docker-related toolchain builds
..

Add documentation for docker-related toolchain builds

This commit adds basic documentation with regard to docker-based
toolchain builds. It breifly outlines how to build images and how to use
them to build the toolchain. I also added the ability to fetch images
from a docker registry. And fixed an 'undefined' variable problem with
docker-based builds.

Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
---
M Makefile
A docker/README.md
M functions.sh
3 files changed, 52 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/10/12810/1
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Thomas Marshall 

[native-toolchain-CR] Add documentation for docker-related toolchain builds

[Laszlo Gaal (Code Review)]

Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12810 )

Change subject: Add documentation for docker-related toolchain builds
..


Patch Set 1:

(6 comments)

Thanks for providing a description for the new build mechanism!

I have a few nits (typos and copy editing), with one location that wasn't 
completely clear to me.

http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@7
PS1, Line 7: related
maybe "based" ?


http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@10
PS1, Line 10: ei
nit: typo


http://gerrit.cloudera.org:8080/#/c/12810/1/Makefile
File Makefile:

http://gerrit.cloudera.org:8080/#/c/12810/1/Makefile@19
PS1, Line 19:   debian8 \
nit: Usually we prefer spaces to tabs


http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md
File docker/README.md:

http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@18
PS1, Line 18: commited
typo: committed


http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@26
PS1, Line 26: ubunu
typo: ubuntu


http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@35
PS1, Line 35: it is possible to specify urls in the DISTROS
: make variable.
Does this mean that specifying this URL would cause the Docker images to be 
fetched from the given registry (instead of building the containers)?



--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:40:13 +
Gerrit-HasComments: Yes