[native-toolchain-CR] IMPALA-12435: Install pinned pip
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. IMPALA-12435: Install pinned pip Fixes installing the desired version of pip. Pulling a specific version of the get-pip script is insufficient to install that version of pip. Installing awscli started failing due to config deprecated in later versions of pip. Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Reviewed-on: http://gerrit.cloudera.org:8080/20465 Reviewed-by: Joe McDonnell Tested-by: Michael Smith --- M docker/all/assert-dependencies-present.py M docker/all/postinstall.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: Verified+1 All images but SLES 12 built successfully. Ran into an unrelated error with SLES 12 trying to pull opensuse.org repos. -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 23:09:32 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: > > Patch Set 3: Code-Review+2 > > > > Thanks for fixing this > > > > Does this help with the ARM container builds? > > No, it runs into a different build failure in ARM containers. > Planning to move to Python 3.8 for them. Darn, well at least we fixed this piece. -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 22:26:22 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: > Patch Set 3: Code-Review+2 > > Thanks for fixing this > > Does this help with the ARM container builds? No, it runs into a different build failure in ARM containers. Planning to move to Python 3.8 for them. -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 22:20:25 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: Code-Review+2 Thanks for fixing this Does this help with the ARM container builds? -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 22:19:57 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20465 to look at the new patch set (#3). Change subject: IMPALA-12435: Install pinned pip .. IMPALA-12435: Install pinned pip Fixes installing the desired version of pip. Pulling a specific version of the get-pip script is insufficient to install that version of pip. Installing awscli started failing due to config deprecated in later versions of pip. Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 --- M docker/all/assert-dependencies-present.py M docker/all/postinstall.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/65/20465/3 -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith
[native-toolchain-CR] IMPALA-12435: Install pinned pip
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20465/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20465/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-12435: Install pinned pip > Please file a JIRA and then also give a bit of info about the error seen. I Done http://gerrit.cloudera.org:8080/#/c/20465/1/docker/all/postinstall.sh File docker/all/postinstall.sh: http://gerrit.cloudera.org:8080/#/c/20465/1/docker/all/postinstall.sh@65 PS1, Line 65: dl_verify https://r > This will not remain constant over time. Is there a specific version that w There's no single version that works. I decided to take this change out for now. http://gerrit.cloudera.org:8080/#/c/20465/1/docker/all/postinstall.sh@72 PS1, Line 72: > I noticed that this command doesn't install 20.3.4 like I thought it did. O Done -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 18:52:51 + Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12435: Install pinned pip, use pip3 when available
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20465 to look at the new patch set (#2). Change subject: IMPALA-12435: Install pinned pip, use pip3 when available .. IMPALA-12435: Install pinned pip, use pip3 when available Fixes installing the desired version of pip. Pulling a specific version of the get-pip script is insufficient to install that version of pip. Installing awscli started failing due to config deprecated in later versions of pip. Also moves to installing awscli to Python 3 when it detects pip3 is available. Other platforms will continue to install pip and use Python 2.7. Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 --- M docker/all/assert-dependencies-present.py M docker/all/postinstall.sh M docker/ubuntu2204.df 3 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/65/20465/2 -- To view, visit http://gerrit.cloudera.org:8080/20465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4667181f9a6ef66c757623f1b128c3faa2057114 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith
