[Impala-ASF-CR] IMPALA-4541: fix test dimensions for test codegen mem limit

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4541: fix test dimensions for test_codegen_mem_limit
..


IMPALA-4541: fix test dimensions for test_codegen_mem_limit

The test should only be run with codegen enabled.

Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
Reviewed-on: http://gerrit.cloudera.org:8080/5221
Reviewed-by: Alex Behm 
Tested-by: Internal Jenkins
---
M tests/query_test/test_query_mem_limit.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Internal Jenkins

[Impala-ASF-CR] IMPALA-4541: fix test dimensions for test codegen mem limit

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4541: fix test dimensions for test_codegen_mem_limit
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4956/14/be/src/codegen/mcjit-mem-mgr.h
File be/src/codegen/mcjit-mem-mgr.h:

PS14, Line 39: ;
>From clang-tidy:

be/src/codegen/mcjit-mem-mgr.h:39:72: warning: extra ';' after member 
function definition [clang-diagnostic-extra-semi]


-- 
To view, visit http://gerrit.cloudera.org:8080/4956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10015b49da182cb181a653ac8464b4a18b71091
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Silvius Rus 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4541: fix test dimensions for test codegen mem limit

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-4541: fix test dimensions for test_codegen_mem_limit
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4540: Function call in DCHECK crashes scheduler

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..


IMPALA-4540: Function call in DCHECK crashes scheduler

The fix for IMPALA-4494 wrapped the call to
backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK,
effectively disabling it in release builds. This leads to a crash when
backend_ip is empty.

This change makes sure that the function is always called.

Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
Reviewed-on: http://gerrit.cloudera.org:8080/5218
Reviewed-by: Michael Ho 
Tested-by: Internal Jenkins
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Michael Ho: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-4540: Function call in DCHECK crashes scheduler

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4541: fix test dimensions for test codegen mem limit

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5221

Change subject: IMPALA-4541: fix test dimensions for test_codegen_mem_limit
..

IMPALA-4541: fix test dimensions for test_codegen_mem_limit

The test should only be run with codegen enabled.

Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
---
M tests/query_test/test_query_mem_limit.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/5221/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac460d2a1b69de638c557d7c8aa318a73ad0507b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong