[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Donghui Xu has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 3: I have resolved the JIRA and changed it's status to resolved. -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 14: I have resolved the JIRA and changed it's status to resolved. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1861: Simplify constant conditionals
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-1861: Simplify constant conditionals .. IMPALA-1861: Simplify constant conditionals When there are conditionals with constant values of TRUE or FALSE we can simplify them during analysis using the ExprRewriter. This patch covers IF, ||, &&, CASE, and DECODE. Change-Id: Id70aaf9fd99f64bd98175b7e2dbba28f350e7d3b --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/CaseWhenClause.java A fe/src/main/java/org/apache/impala/rewrite/ConstantPredicateRule.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M testdata/workloads/functional-planner/queries/PlannerTest/empty.test 5 files changed, 204 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/5585/2 -- To view, visit http://gerrit.cloudera.org:8080/5585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id70aaf9fd99f64bd98175b7e2dbba28f350e7d3b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-1861: Simplify constant conditionals
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5585 Change subject: IMPALA-1861: Simplify constant conditionals .. IMPALA-1861: Simplify constant conditionals When there are conditionals with constant values of TRUE or FALSE we can simplify them during analysis using the ExprRewriter. This patch covers IF, ||, &&, CASE, and DECODE. Change-Id: Id70aaf9fd99f64bd98175b7e2dbba28f350e7d3b --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/CaseWhenClause.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M testdata/workloads/functional-planner/queries/PlannerTest/empty.test 4 files changed, 57 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/5585/1 -- To view, visit http://gerrit.cloudera.org:8080/5585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id70aaf9fd99f64bd98175b7e2dbba28f350e7d3b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 3: Thanks again for your contribution - please resolve the JIRA when you get a chance. -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4710: There is an error in control audit log file size number .. IMPALA-4710: There is an error in control audit log file size number The comparison logic of log file size and maximum config is wrong, leading to log file size is greater than the maximum config. This patch corrects the error, makes both are consistent. Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Reviewed-on: http://gerrit.cloudera.org:8080/5582 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/util/simple-logger.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/137/ -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 2: Code-Review+2 Rebased onto master -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4710: There is an error in control audit log file size number .. Patch Set 1: Code-Review+2 Nice catch -- To view, visit http://gerrit.cloudera.org:8080/5582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 14: Thanks for your contribution! Please go ahead and resolve the JIRA when you have a chance. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
