[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6267 Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references .. [DOCS] Wide-ranging cleanup of CDH and Cloudera references Genericize 3-part version numbers in "known issues". Genericize CDH version numbers in 'ports' topic. Genericize 'Cloudera' and hostnames in 'Tables' topic. Genericize the version numbers in 'added in' blurbs. Remove lots of CDH / Impala notices from release notes. Remove obsolete conref'able elements that weren't actually being called from anywhere, that contained CDH version number wording. Reword 'Cloudera recommends'. Remove more hidden or commented material with Cloudera-specific wording. Remove obsolete CDH references from 'incompatible changes'. Change 'cloudera' HDFS username for LOAD DATA examples. Remove material related to big lists of CDH fixed JIRAs. Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala.xml M docs/topics/impala_compute_stats.xml M docs/topics/impala_create_function.xml M docs/topics/impala_decimal.xml M docs/topics/impala_describe.xml M docs/topics/impala_drop_function.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_known_issues.xml M docs/topics/impala_load_data.xml M docs/topics/impala_misc_functions.xml M docs/topics/impala_new_features.xml M docs/topics/impala_perf_stats.xml M docs/topics/impala_ports.xml M docs/topics/impala_prereqs.xml M docs/topics/impala_revoke.xml M docs/topics/impala_runtime_filtering.xml M docs/topics/impala_s3.xml M docs/topics/impala_show.xml M docs/topics/impala_tables.xml M docs/topics/impala_timestamp.xml M docs/topics/impala_tutorial.xml M docs/topics/impala_v_cpu_cores.xml M docs/topics/impala_varchar.xml 26 files changed, 172 insertions(+), 752 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6267/1 -- To view, visit http://gerrit.cloudera.org:8080/6267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Sounds good - I commented on the bugfix, hopefully we can get these both in quickly. -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: No
[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 1: I don't fully understand the JNI model, but I'm wondering if this is exactly the right fix. Looking at https://github.com/apache/incubator-impala/blob/master/be/src/util/backend-gflag-util.cc#L73, it seems to me that cfg_bytes is allocated on a local frame instantiated in GetThriftBackendGflags(). That frame is then popped at the end of the method, so does cfg_bytes then go out of scope at that point (i.e. earlier than this patch assumes)? Maybe try forcing a GC after GetThriftBackendGflags() to see if the reference is collected? I admit to not really understanding why the local frame is needed, so I'm probably missing something. -- To view, visit http://gerrit.cloudera.org:8080/6264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. .. Patch Set 3: (9 comments) Please review these so we can get them pushed to master http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: PS2, Line 224: Although the Impala admission control feature uses a fair-scheduler.xml configuration file : behind the scenes, this file does not depend on which scheduler is used for YARN. > Should we duplicate content or only hide the sentence/phrase with Cloudera John's strategy was to hide the content in this pass and rewrite to NOT use "Cloudera Manager" and then the hidden content will be taken care of in a subsequent clean up task. Line 654: To configure admission control, use a combination of startup options for the Impala daemon and edit > add comma; the sentence left behind reads awkwardly -- you could probably r Rewrote to: To configure admission control, use a combination of startup options for the Impala daemon and edit or create the configuration files fair-scheduler.xml and llama-site.xml. PS2, Line 717: ing the > After hiding the CM section, you're left with only 1 example. Done http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_noncm_installation.xml File docs/topics/impala_noncm_installation.xml: PS2, Line 109: (For CDH 4, this is a different repository than for CDH.) > I think you can delete this. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. Line 140: Cloudera recommends that you not install Impala on any HDFS NameNode. Installing Impala on NameNodes > hide? John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_prereqs.xml File docs/topics/impala_prereqs.xml: Line 86: software requirements > Explicitly list the supported OSs. They were originally hidden because we w John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. PS2, Line 93: The relevant supported operating systems : and versions for Impala are the same as for the corresponding CDH 5 > Remove or hide this sentence. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: Line 58: > assorted references to CDH and CM quickstart in this list. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. Line 134: Copyright (c) 2012 Cloudera, Inc. All rights reserved. > Remove references to cloudera from all the code samples. Several scattered John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 2: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. Patch Set 3: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 1: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 1: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: @Henry: The GVO of this patch exposed an unrelated bug that I fixed in another CR [1]. I'll GVO this again once that is merged. [1] https://gerrit.cloudera.org/#/c/6264 -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: No
[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/6264 Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Fix a potential crash in Frontend & Catalog JNI startup Bug: In the startup of the Frotend and the Catalog JVMs, we incorrectly use a local reference that can potentially be GC'ed by the JVM. Any usage of that reference can result in an undefined behavior or a JVM crash. Fix: Move the reference to a global state and eventually free it after the startup. Testing: We can reliably reproduce this crash with the dynamic log levels patch [1] in the following backend tests which start multiple Frontend instances in parallel. - buffered-block-mgr-test - buffered-tuple-stream-test - buffer-pool-test With this patch, all the above tests pass. [1] https://gerrit.cloudera.org/#/c/5792/ Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f --- M be/src/catalog/catalog.cc M be/src/service/frontend.cc 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6264/1 -- To view, visit http://gerrit.cloudera.org:8080/6264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada
