[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/405/ -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4041: Limit catalog and admission control updates to
coordinators
..
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
Line 183: request_pool_service_.get(), metrics_.get(),
backend_address_));
> Hm, I am not sure this is possible. This is the ExecEnv constructor, is it
never mind, i lost track of where i was.
http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
Line 336: std::vector* topic_updates) {
remove std::
Line 343: std::vector* topic_updates) {
remove std::
Line 1579: const std::string local_backend_id = exec_env_->subscriber()->id();
remove std::
Line 1589: LOG(WARNING) << "Failed to convert hostname " << hostname << "
to IP address";
but keep going?
Line 1592: subscriber_topic_updates->push_back(TTopicDelta());
emplace_back()
Line 1595: update.topic_entries.push_back(TTopicItem());
emplace_back()
http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:
Line 436: // backends. If not, add it and tell the statestore. Even though
the same
'and tell the statestore'? doesn't something else do that part?
describe side effects (add to topic_updates and known_backends_).
--
To view, visit http://gerrit.cloudera.org:8080/6344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis
Gerrit-Reviewer: Dimitris Tsirogiannis
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Marcel Kornacker
Gerrit-Reviewer: Matthew Jacobs
Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump Kudu client version to 16dd6e4
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client version to 16dd6e4 Also sets the Java client version to 1.4.0-cdh5.12.0-SNAPSHOT Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Reviewed-on: http://gerrit.cloudera.org:8080/6423 Reviewed-by: Matthew Jacobs Tested-by: Impala Public Jenkins --- M bin/impala-config.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Bump Kudu client version to 16dd6e4
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/405/ -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: failure seems unrelated to the change, it looks like https://jira.cloudera.com/browse/CDH-51791 I'll try again -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/403/ -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into table refs and inline views, they can be considered for constant progagation within that node. In certain cases, we might end up with a FALSE conditional and now we can convert ScanNodes to EmptySet nodes when that occurs. Testing: Expanded the test cases for the planner to achieve constant propagation. Added Kudu, datasource, Hdfs and HBase tests to validate we can create EmptySetNodes Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/SelectList.java M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test A testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test 17 files changed, 462 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/6389/9 -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function
anujphadke has abandoned this change. Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Abandoned Had posted this for debugging and evaluating usage of decimalValue. -- To view, visit http://gerrit.cloudera.org:8080/6206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I98f3771de1756a5c3c75b72bf172511e36aca513 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke
[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function
anujphadke has posted comments on this change.
Change subject: IMPALA-4848: Add WIDTH_BUCKET() function
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/6023/3//COMMIT_MSG
Commit Message:
PS3, Line 7: WIDTH_BUCKET()
> Nit that's bugging me: spelling :)
Done
http://gerrit.cloudera.org:8080/#/c/6023/3/be/src/exprs/math-functions-ir.cc
File be/src/exprs/math-functions-ir.cc:
Line 445:
> use numeric_limits instead of INT32_MAX
Done
Line 456:
> To simplify the handling of these strange cases, you might consider using D
Done
Line 460: ctx->SetError("Overflow while bucket_width evaluation");
> UNLIKELY
Done
Line 461: return IntVal::null();
> put parenthesis around the division to make the intended evaluation order c
This code has changed.
Line 462: }
> Same comment as above for infinity. I don't think we can have infinity here
not needed with the decimalVal changes
--
To view, visit http://gerrit.cloudera.org:8080/6023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: anujphadke
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function
anujphadke has uploaded a new patch set (#4). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. IMPALA-4848: Add WIDTH_BUCKET() function Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f --- M be/src/exprs/expr-test.cc M be/src/exprs/math-functions-ir.cc M be/src/exprs/math-functions.h M common/function-registry/impala_functions.py M fe/src/main/java/org/apache/impala/analysis/Expr.java 5 files changed, 124 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/6023/4 -- To view, visit http://gerrit.cloudera.org:8080/6023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into table refs and inline views, they can be considered for constant progagation within that node. In certain cases, we might end up with a FALSE conditional and now we can convert ScanNodes to EmptySet nodes when that occurs. Testing: Expanded the test cases for the planner to achieve constant propagation. Only thing missing right now is Kudu tests. Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/SelectList.java M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test A testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test 15 files changed, 356 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/6389/8 -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into table refs and inline views, they can be considered for constant progagation within that node. In certain cases, we might end up with a FALSE conditional and now we can convert ScanNodes to EmptySet nodes when that occurs. Testing: Expanded the test cases for the planner to achieve constant propagation. Only thing missing right now is Kudu tests. Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/SelectList.java M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test A testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test A testdata/workloads/visa 16 files changed, 357 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/6389/7 -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Zach Amsden
[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)
Henry Robinson has posted comments on this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Patch Set 1: Code-Review+2 Verified+1 I feel pretty good giving this a +2 myself (we discussed this internally). Let me know if there's an issue. -- To view, visit http://gerrit.cloudera.org:8080/6450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d6abe Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)
Henry Robinson has submitted this change and it was merged. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d6abe --- A LICENSE.txt 1 file changed, 732 insertions(+), 0 deletions(-) Approvals: Henry Robinson: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/6450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d6abe Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6439 to look at the new patch set (#5). Change subject: [DOCS] Genericize LZO setup instructions .. [DOCS] Genericize LZO setup instructions Take out the Cloudera-specific download URLs for the impala-lzo package. Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b --- M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_txtfile.xml 2 files changed, 4 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/5 -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6439/4/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS4, Line 491: : : The download details for the impala-lzo package are under construction. : : After discussion, decided to take out this too. -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump Kudu client version to 16dd6e4
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/404/ -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu client version to 16dd6e4
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu client version to 16dd6e4
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6423 to look at the new patch set (#2). Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client version to 16dd6e4 Also sets the Java client version to 1.4.0-cdh5.12.0-SNAPSHOT Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 --- M bin/impala-config.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/6423/2 -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a8074640a6b93b5a65a1e0e2f22c7fe78754ad1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/403/ -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Michael Brown has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
David Knupp has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+1 I agree -- I don't see any downsides to scoping the connection fixture at test level. -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from it's children without materializing. This is done in the case when the child's tuple layout is identical to union node tuple layout and no functions need to be applied to the child row batches. Removed operand reordering in the FE because it's simpler and safer to handle all passthrough children before non-passthrough children in the BE. The recent improvements to memory management allowed us to remove this requirement. Testing: - Added new planner and end to end tests that cover the new functionality. - Updated existing tests to reflect the new behavior. Perf: Ran a benchmark on a local 10 GB tpcds dataset. I used an unpartitioned version of the store_sales table. There was over a 2x performance improvement for the following query: SELECT COUNT(ss_sold_time_sk), COUNT(ss_item_sk), COUNT(ss_customer_sk), COUNT(ss_cdemo_sk), COUNT(ss_hdemo_sk), COUNT(ss_addr_sk), COUNT(ss_store_sk), COUNT(ss_promo_sk), COUNT(ss_ticket_number), COUNT(ss_quantity), COUNT(ss_wholesale_cost), COUNT(ss_list_price), COUNT(ss_sales_price), COUNT(ss_ext_discount_amt), COUNT(ss_ext_sales_price), COUNT(ss_ext_wholesale_cost), COUNT(ss_ext_list_price), COUNT(ss_ext_tax), COUNT(ss_coupon_amt), COUNT(ss_net_paid), COUNT(ss_net_paid_inc_tax), COUNT(ss_net_profit), COUNT(ss_sold_date_sk) FROM ( select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned union all select * from tpcds_10_parquet.store_sales_unpartitioned ) t Before: Total Time: 43s164ms Summary: Operator #Hosts Avg Time Max Time#Rows Est. #Rows Peak Mem Est. Peak Mem Detail -- 13:AGGREGATE 1 224.721us 224.721us1 1 28.00 KB -1.00 B FINALIZE 12:EXCHANGE1 24.578us 24.578us3 1 0 -1.00 B UNPARTITIONED 11:AGGREGATE 32s402ms3s060ms3 1 119.00 KB 10.00 MB 00:UNION 3 35s380ms 37s846ms 288.01M 288.01M3.08 MB 0 |--02:SCAN HDFS3 184.197ms 219.931ms 28.80M 28.80M 535.03 MB 1.88 GB store_sales_unpartitioned |--03:SCAN HDFS3 131.956ms 153.401ms 28.80M 28.80M 534.98 MB 1.88 GB store_sales_unpartitioned |--04:SCAN HDFS3 178.456ms 247.721ms 28.80M 28.80M 534.98 MB 1.88 GB store_sales_unpartitioned |--05:SCAN HDFS3 189.398ms 242.251ms 28.80M 28.80M 535.01 MB 1.88 GB store_sales_unpartitioned |--06:SCAN HDFS3 122.786ms 156.528ms 28.80M 28.80M 534.98 MB 1.88 GB store_sales_unpartitioned |--07:SCAN HDFS3 147.467ms 183.391ms 28.80M 28.80M 535.13 MB 1.88 GB store_sales_unpartitioned |--08:SCAN HDFS3 147.502ms 186.273ms 28.80M 28.80M 535.01 MB 1.88 GB store_sales_unpartitioned |--09:SCAN HDFS3 130.086ms 154.682ms 28.80M 28.80M 535.04 MB 1.88 GB store_sales_unpartitioned |--10:SCAN HDFS3 122.701ms 161.056ms 28.80M 28.80M 534.89 MB 1.88 GB store_sales_unpartitioned 01:SCAN HDFS 3 287.863ms 330.436ms 28.80M 28.80M 534.98 MB 1.88 GB store_sales_unpartitioned After: Total Time: 19s139ms Summary: Operator #Hosts Avg Time Max Time#Rows Est. #Rows Peak Mem Est. Peak Mem Detail -- 13:AGGREGATE 1 166.241us 166.241us1 1 28.00 KB -1.00 B FINALIZE 12:EXCHANGE1 71.695us 71.695us3 1 0 -1.00 B UNPARTITIONED 11:AGGREGATE 32s971ms3s809ms3 13.08 MB 10.00 MB 00:UNION 3 207.956ms 222.846ms 288.01M 288.01M 0 0 |--02:SCAN HDFS31s533ms1s535ms 28.80M 28.80M 532.28 MB
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all URLs in *keydefs* file that point to issues.cloudera.org. Update all tags in the doc source that point to individual JIRA issues on issues.cloudera.org. (Leave alone links pointing to JIRA reports; those don't seem to be redirected currently.) Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Reviewed-on: http://gerrit.cloudera.org:8080/6452 Reviewed-by: Laurel Hale Reviewed-by: Michael Brown Reviewed-by: John Russell Tested-by: Impala Public Jenkins --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_drop_stats.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_known_issues.xml M docs/topics/impala_new_features.xml 7 files changed, 10,393 insertions(+), 10,413 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Brown: Looks good to me, but someone else must approve Laurel Hale: Looks good to me, but someone else must approve John Russell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/105/ -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6453 Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. IMPALA-5079: Bump timeout for TestKuduOperations Tests seem to be timing out similarly to IMPALA-4454. Bump the timeout to unblock tests for now. This also changes the pytest 'scope' of the 'conn' fixture which seems suspicious given that some state may be shared between test cases (within the class). The primary concern with removing this is that per-test connections being created might increase the test execution time, but on a test run I found it not to have any measurable effect. Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 --- M tests/conftest.py M tests/query_test/test_kudu.py 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/6453/1 -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fd8e5eb5dbd977c386e6557941a2c47de44f344 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Michael Brown has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+1 My concerns are addressed. -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+1 Built cleanly, fixes display as expected in all files after a spot check (both html & pdf) -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap File docs/impala_keydefs.ditamap: PS1, Line 316: https://issues.apache.org/jira/browse/IMPALA-1"; scope="external" format="html" keys="IMPALA-1"/> > Unrelated to this review, but: This is wild! Is there a way to just have a No, XML really likes the generated output to be extremely predictable based on simple parsing of the input source files. Sometimes we employ postprocessing but (a) that's more complicated for an open source user to set up, and (b) the result would only apply to HTML output, whereas these links will work equally in HTML and PDF. http://gerrit.cloudera.org:8080/#/c/6452/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: PS1, Line 50: https://issues.apache.org/"; scope="external" format="html">issues.apache.org JIRA tracker. > If you look https://issues.apache.org/ is a page that gives you links to va Done -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all URLs in *keydefs* file that point to issues.cloudera.org. Update all tags in the doc source that point to individual JIRA issues on issues.cloudera.org. (Leave alone links pointing to JIRA reports; those don't seem to be redirected currently.) Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_drop_stats.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_known_issues.xml M docs/topics/impala_new_features.xml 7 files changed, 10,393 insertions(+), 10,413 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6452/2 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Michael Brown has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: (2 comments) I need to set up dita locally before I give you any pluses, but here are my comments so far. http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap File docs/impala_keydefs.ditamap: PS1, Line 316: https://issues.apache.org/jira/browse/IMPALA-1"; scope="external" format="html" keys="IMPALA-1"/> Unrelated to this review, but: This is wild! Is there a way to just have a macro so that these things "just work" without all the explicit definitions? http://gerrit.cloudera.org:8080/#/c/6452/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: PS1, Line 50: https://issues.apache.org/"; scope="external" format="html">issues.apache.org JIRA tracker. If you look https://issues.apache.org/ is a page that gives you links to various bug-tracking sites for ASF. Maybe prefer https://issues.apache.org/jira/ when talking about the top-level site? -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: The changes to the tags pointing to Impala issues were done by macro, so if the basic pattern is correct I don't they need to be checked one-by-one. I also found a couple of HIVE- JIRA URLs pointing to issues.cloudera.org. I confirmed that the equivalent issues.apache.org/jira URLs worked and so changed those links where appropriate. -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6452 Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all URLs in *keydefs* file that point to issues.cloudera.org. Update all tags in the doc source that point to individual JIRA issues on issues.cloudera.org. (Leave alone links pointing to JIRA reports; those don't seem to be redirected currently.) Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_drop_stats.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_known_issues.xml M docs/topics/impala_new_features.xml 7 files changed, 10,393 insertions(+), 10,413 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6452/1 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Laurel Hale has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: Code-Review+1 Patch 4 builds cleanly and the content renders well in the html & pdf output. -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] Pass build type to Impala LZO.
Jim Apple has posted comments on this change. Change subject: Pass build type to Impala LZO. .. Patch Set 1: Fixes https://issues.apache.org/jira/browse/IMPALA-4699? -- To view, visit http://gerrit.cloudera.org:8080/6446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS1, Line 538: > Replace this 'cdh' portion of the filename with a generic placeholder. Done http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS2, Line 562: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : > IN particular this section and one at the top seem likely to be universal, I'm happy either way. With partial instructions left in, Apache Impala users might be able to puzzle through the rest of it themselves. I'll put those pieces back. It isn't clear to me though exactly how much of the earlier stuff is really relevant. (Will Apache Impala users run any apt-get / yum / zypper commands at all or would they be building both impala-lzo and hadoop-lzo from source?) -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6439 to look at the new patch set (#4). Change subject: [DOCS] Replace LZO setup instructions with placeholder .. [DOCS] Replace LZO setup instructions with placeholder An "under construction" banner since non-Cloudera-specific URLs are not available at this time, and the information itself may be out of date / inapplicable for Apache Impala project users. Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b --- M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_txtfile.xml 2 files changed, 9 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/4 -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] Pass build type to Impala LZO.
Tim Armstrong has posted comments on this change. Change subject: Pass build type to Impala LZO. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Genericize references to ODBC driver versions .. [DOCS] Genericize references to ODBC driver versions Make the statement about who uses which ports for Impala less specific w.r.t. the Cloudera ODBC driver. Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Reviewed-on: http://gerrit.cloudera.org:8080/6440 Reviewed-by: John Russell Tested-by: Impala Public Jenkins --- M docs/topics/impala_ports.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified John Russell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/104/ -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
John Russell has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Code-Review+2 (1 comment) Combining resolution for Jim's comment with promoting Laurel's +1. http://gerrit.cloudera.org:8080/#/c/6440/1/docs/topics/impala_ports.xml File docs/topics/impala_ports.xml: PS1, Line 94: ODBC drivers > elide here and below Done -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6440 to look at the new patch set (#2). Change subject: [DOCS] Genericize references to ODBC driver versions .. [DOCS] Genericize references to ODBC driver versions Make the statement about who uses which ports for Impala less specific w.r.t. the Cloudera ODBC driver. Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 --- M docs/topics/impala_ports.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/6440/2 -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With this commit we add the ability to limit catalog updates to a limited set of coordinator nodes. A new startup option, termed 'is_coordinator' is added to indicate if a node is a coordinator. Coordinators accept connections through HS2 and Beeswax interfaces and can also participate in query execution. Non-coordinator nodes do not receive catalog updates from the statestore, do not initialize a query scheduler and cannot accept Beeswax and HS2 client connections. Testing: - Added a custom cluster test that launches a cluster in which the number of coordinators is less than the cluster size and runs a number of smoke queries. - Successfully run exhaustive tests. Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 --- M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/scheduler-test-util.cc M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/impalad-main.cc M be/src/service/query-exec-state.cc M be/src/testutil/in-process-servers.h M bin/start-impala-cluster.py M tests/common/custom_cluster_test_suite.py M tests/common/impala_service.py A tests/custom_cluster/test_coordinators.py 16 files changed, 363 insertions(+), 172 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/6344/3 -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4041: Limit catalog and admission control updates to
coordinators
..
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
Line 183: request_pool_service_.get(), metrics_.get(),
backend_address_));
> no need to pass in backend_address_, you can get that with ExecEnv::GetInst
Hm, I am not sure this is possible. This is the ExecEnv constructor, is it safe
to call ExecEnv::GetInstance() when AdmissionController and Scheduler are
initialized here? Maybe I am missing something.
Line 228: if (FLAGS_use_statestore && statestore_port > 0) {
> let's please not file a jira for something this small, the time involved in
There is already a TODO. Done
Line 349: if (admission_controller_ != NULL)
RETURN_IF_ERROR(admission_controller_->Init());
> replace all NULL w/ nullptr in this file (and any other file you touch wher
Done
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
Line 38: DECLARE_bool(is_coordinator);
> unused
Done
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/scheduling/admission-controller.h
File be/src/scheduling/admission-controller.h:
Line 210: /// Subscription manager
> owned?
Done
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
Line 341: bind(mem_fn(&ImpalaServer::CatalogUpdateCallback),
this, _1, _2);
> use lambda, unless impractical. you can also inline that in the call.
Done
Line 1484: // Check if the local backend descriptor is in the list of known
> this function is already too long. break this up.
Previously, it was the scheduler's responsibility to update the list of
backends in the statestore. Given that the scheduler may not start in all the
nodes, we need this update to happen elsewhere.
I've extracted this into a separate function which is invoked only for
non-coordinator nodes.
Line 1903: // Only for coordinators, initialize the HS2 and Beeswax services.
> rephrase to fix grammar
Done
http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:
Line 955: /// Impala server is a coordinator (dictated from the is_coordinator
flag).
> "indicated by the .. flag"
Done
http://gerrit.cloudera.org:8080/#/c/6344/2/tests/custom_cluster/test_coordinators.py
File tests/custom_cluster/test_coordinators.py:
Line 42: client = worker.service.create_beeswax_client()
> same for hs2?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis
Gerrit-Reviewer: Dimitris Tsirogiannis
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Marcel Kornacker
Gerrit-Reviewer: Matthew Jacobs
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 21: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/402/ -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6450 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d6abe --- A LICENSE.txt 1 file changed, 732 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/6450/1 -- To view, visit http://gerrit.cloudera.org:8080/6450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d6abe Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)
Henry Robinson has abandoned this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I501dd7d456a26959d1eae4400fea9ffb2d6a7188 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I203ce935070b18d56d7f7e5a57827e355c28479e Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Matthew Jacobs
[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id6597db80e3a14b3d251909f2c08ef4655b2f915 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6447 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 Kudu tag 'kudu5.10.0-rc3' Change-Id: I203ce935070b18d56d7f7e5a57827e355c28479e --- M buildall.sh A source/kudu/kudu-kudu5.10.0-rc3-patches/0001-CDH-48124.patch 2 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/47/6447/1 -- To view, visit http://gerrit.cloudera.org:8080/6447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I203ce935070b18d56d7f7e5a57827e355c28479e Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Matthew Jacobs
[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6449 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: I501dd7d456a26959d1eae4400fea9ffb2d6a7188 --- A LICENSE.txt 1 file changed, 732 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/6449/1 -- To view, visit http://gerrit.cloudera.org:8080/6449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I501dd7d456a26959d1eae4400fea9ffb2d6a7188 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6448 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 Kudu tag 'kudu5.10.0-rc4' Change-Id: Id6597db80e3a14b3d251909f2c08ef4655b2f915 --- M buildall.sh A source/kudu/kudu-kudu5.10.0-rc4-patches 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/48/6448/1 -- To view, visit http://gerrit.cloudera.org:8080/6448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6597db80e3a14b3d251909f2c08ef4655b2f915 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Tim Armstrong
