[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7615 Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur The buffer pool changes reduced the memory requirement for the sort, which seems to have been enough to get the query to execute without spilling on S3. Reduce the limit in the test to force it to spill. Testing: Ran in a loop locally for an hour. Ran custom cluster tests on S3. Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 --- M tests/custom_cluster/test_scratch_disk.py 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7615/1 -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1015/ -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5661: buffer pool limit .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1014/ -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1013/ -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1012/ -- To view, visit http://gerrit.cloudera.org:8080/7609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1011/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5768: Better developer documentation
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#5). Change subject: IMPALA-5768: Better developer documentation .. IMPALA-5768: Better developer documentation Guide to important environment variables for build, impala paths and config cleanup. Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 --- M README.md M bin/impala-config.sh 2 files changed, 75 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/7350/5 -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Bharath Vissapragada has abandoned this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Abandoned Moved to CR:7588 -- To view, visit http://gerrit.cloudera.org:8080/7603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 3: Code-Review+1 (2 comments) Adding Alex to do a +2 review. http://gerrit.cloudera.org:8080/#/c/7588/3//COMMIT_MSG Commit Message: Line 10: Add test case for testing the failure when a subquery is used in the ON clause. nit: limit to 70chars per line in commit messages. PS3, Line 12: Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff Remove. (Gerrit's commit hook uses the change-Id to map the commit to the corresponding code review. Multiple change-ids can send out duplicate reviews). -- To view, visit http://gerrit.cloudera.org:8080/7588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1010/ -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. IMPALA-5774: Prevent FindInSet() from reading off end of string Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Reviewed-on: http://gerrit.cloudera.org:8080/7608 Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M be/src/exprs/string-functions-ir.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Sailesh Mukil: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 10: Code-Review+2 Thanks for the review! Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Pranay Singh has uploaded a new patch set (#3). Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. IMPALA-1478: Improve error message when subquery is used in the ON clause Fix: Print the error stating that "Suquery not allowed in the ON clause" Add test case for testing the failure when a subquery is used in the ON clause. Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2 --- M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7588/3 -- To view, visit http://gerrit.cloudera.org:8080/7588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5661: buffer pool limit .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1009/ -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5661: buffer pool limit .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1008/ -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5661: buffer pool limit .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1007/ -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: It looks like you're hitting a known-flaky test: https://issues.apache.org/jira/browse/IMPALA-5760 -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5661: buffer pool limit
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7462/4//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5661: buffer pool limit
> Add "Adds a ... flag" or similar
Done
http://gerrit.cloudera.org:8080/#/c/7462/4/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
PS4, Line 49: specified "
: "as number of bytes ('[bB]?'), megabytes
('[mM]'), "
: "gigabytes ('[gG]'), or percentage of the process
memory limit ('%'). "
: "Defaults to bytes if no unit is given.
> can you factor out this string that we repeat constantly in gflag descripti
Done. I could only find 3 instances of it.
--
To view, visit http://gerrit.cloudera.org:8080/7462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5661: buffer pool limit .. IMPALA-5661: buffer pool limit Adds the --buffer_pool_limit flag to control the buffer pool size. It can be specified as either an absolute memory value or a percentage of the process memory limit Testing: Started up a cluster with --buffer_pool_limit=10%, confirmed via /metrics page that the buffer pool limit was reduced to ~800MB on my system. Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d --- A be/src/common/constant-strings.h M be/src/common/global-flags.cc M be/src/runtime/exec-env.cc M be/src/scheduling/request-pool-service.cc 4 files changed, 68 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/7462/5 -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: I will test the rebased version again. -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1002/ -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(5 comments)
Addressed the comments. Was in the middle of a rebase onto the buffer pool
changes so that is also included.
The rebase removed BufferedBlockMgr but required calling MemTracker::Close()
from InitialReservaitons.
http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:
Line 154: DCHECK(!all_trackers_[i]->has_limit());
> Can we also add DCHECK(!all_tracker_[i]->closed_) here ?
Done. Cleaned up some of the iteration over all_trackers_ to use ranged for
loops.
Line 210: void Release(int64_t bytes) {
> Based on the comments in Close(), we may also consider calling DCHECK(!clos
Done. Agree with the reasoning.
Line 212: if (bytes < 0) Consume(-bytes);
:/ I hope we're not calling this with negative values. Seems weird.
Line 235: /// TODO: Release brokered memory?
Will remove this LLAMA-related TODO
http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
Line 1: // regarding copyright ownership. The ASF licenses this file
> nit: I think you deleted part of the copyright message by accident.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 4: Going to run tests under ASAN before merging -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1006/ -- To view, visit http://gerrit.cloudera.org:8080/7609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
Tim Armstrong has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7467/2//COMMIT_MSG Commit Message: Line 9: Googletest supports sharded execution, where multiple independent IIRC ctest also supports running multiple tests in parallel. How would the sharding fit with that? Would we shard big tests and run smaller tests in parallel? Line 30: Each shard process logs to its own directory 'foo_test_shard_N' under How would I know which output file to look at? http://gerrit.cloudera.org:8080/#/c/7467/2/bin/run-backend-tests.sh File bin/run-backend-tests.sh: Line 40: # mode. This includes all sharded tests, but also the non-sharded versions of any test The approach seems reasonable unless there's some built-in way to do this. Line 72: set +e What's this for? http://gerrit.cloudera.org:8080/#/c/7467/2/bin/run-sharded-test.sh File bin/run-sharded-test.sh: PS2, Line 35: NUM_SHARDS We should probably document this along with the input args. -- To view, visit http://gerrit.cloudera.org:8080/7467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865db25b07728f3886133316ded5122c60490967 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5661: buffer pool limit
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7462/4//COMMIT_MSG
Commit Message:
Line 7: IMPALA-5661: buffer pool limit
Add "Adds a ... flag" or similar
http://gerrit.cloudera.org:8080/#/c/7462/4/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
PS4, Line 49: specified "
: "as number of bytes ('[bB]?'), megabytes
('[mM]'), "
: "gigabytes ('[gG]'), or percentage of the process
memory limit ('%'). "
: "Defaults to bytes if no unit is given.
can you factor out this string that we repeat constantly in gflag descriptions?
--
To view, visit http://gerrit.cloudera.org:8080/7462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Matthew Jacobs
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:
Line 154: DCHECK(!all_trackers_[i]->has_limit());
Can we also add DCHECK(!all_tracker_[i]->closed_) here ?
Line 210: void Release(int64_t bytes) {
Based on the comments in Close(), we may also consider calling DCHECK(!closed_)
here because the contract is that the counters are safe to be destroyed after
calling Close() and we already DCHECK consumption is 0 in Close().
--
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 6: Code-Review+2 Forgot to add the couple of lines of code to enable this in the BE and FE servers :/ Done now, carry +2. -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1005/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7524 to look at the new patch set (#6). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using TLS / Thrift The 'cipher suite' is a description of the set of algorithms used by SSL and TLS to execute key exchange, encryption, message authentication, and random number generation functions. SSL implementations allow the cipher suite to be configured so that ciphers may be removed from the whitelist if they are shown to be weak. * Add a flag --ssl_cipher_list which controls cipher selection for both thrift servers and clients. Default is blank, which means use all available cipher suites. * Add ThriftServerBuilder to simplify construction of ThriftServers (whose constructors were otherwise getting very long). Testing: new tests added to thrift-server-test. Test cases added follow: * A client cannot connect to a server which does not have any ciphers in common with it. * If ciphers are identical on clients and servers, that ssl connections can be made. * Bad cipher strings lead to errors on both client and server. Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f --- M be/src/benchmarks/network-perf-benchmark.cc M be/src/catalog/catalogd-main.cc M be/src/rpc/thrift-client.cc M be/src/rpc/thrift-server-test.cc M be/src/rpc/thrift-server.cc M be/src/rpc/thrift-server.h M be/src/runtime/data-stream-test.cc M be/src/service/impala-server.cc M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestored-main.cc M be/src/testutil/in-process-servers.cc A be/src/testutil/scoped-flag-setter.h M be/src/util/webserver-test.cc 13 files changed, 440 insertions(+), 143 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/7524/6 -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 1: // regarding copyright ownership. The ASF licenses this file nit: I think you deleted part of the copyright message by accident. -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
Henry Robinson has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Only in the sense that I was hoping for some feedback on the approach (e.g. is it a good idea, running N test processes at the same time, logging to different places - will it be more painful to find an error message after the fact)? -- To view, visit http://gerrit.cloudera.org:8080/7467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865db25b07728f3886133316ded5122c60490967 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
Tim Armstrong has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Is this still a preview only? -- To view, visit http://gerrit.cloudera.org:8080/7467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865db25b07728f3886133316ded5122c60490967 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:
PS3, Line 114: if (closed_) return;
> Why this change ? Why not always have the DCHECK() below ?
I don't think the DCHECK necessarily makes sense if there's a consumption
metric. E.g. if it's the TCMalloc consumption, it's probably not going to be
exactly zero.
I guess we never Close() a MemTracker with a consumption metric so it's
academic at the moment. I can remove the condition if you think it's clearer.
PS3, Line 200: mTracker::~MemTracker() {
> Ideally, we'd like to have a DCHECK(closed_) here if we fix up all backend
Yeah I agree. I went through and looked at the tests and it seemed like a lot
of added code for not much benefit. I made this a little stricter by checking
whether it's running in a backend test.
http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
Line 80: // and they can be safely destroyed.
> nit: long line
Done
--
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7492 to look at the new patch set (#4). Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. IMPALA-5715: (mitigation only) defer destruction of MemTrackers One potential candidate for the bad MemTracker IMPALA-5715 is one owned by a join build sink. I haven't found a clear root cause, but we can reduce the probability of bugs like this by deferring teardown of the MemTrackers. This patch defers destruction of the fragment instance, ExecNode, DataSink and Codegen MemTrackers until query teardown. Instead MemTracker::Close() is called at the place where the MemTracker would have been destroyed to check that all memory is released and enforce that no more memory is consumed. The entire query MemTracker subtree is then disconnected in whole from the global tree in QueryState::ReleaseResources(), instead of the MemTrackers being incrementally disconnected bottom-up. In cases where the MemTracker is owned by another object, this required deferring teardown of the owner until query teardown. E.g. for LlvmCodeGen I added a Close() method to release resources and deferred calling the destructor. We want to make this change anyway - see IMPALA-5587. Testing: Ran a core ASAN build. Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f --- M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/data-sink.cc M be/src/exec/exchange-node.cc M be/src/exec/exec-node.cc M be/src/exec/nested-loop-join-node.cc M be/src/exprs/expr-codegen-test.cc M be/src/runtime/buffered-block-mgr.cc M be/src/runtime/bufferpool/reservation-tracker-test.cc M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/data-stream-recvr.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M be/src/runtime/query-state.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h 20 files changed, 122 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/7492/4 -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5661: buffer pool limit
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5661: buffer pool limit .. IMPALA-5661: buffer pool limit Testing: Started up a cluster with --buffer_pool_limit=10%, confirmed via /metrics page that the buffer pool limit was reduced to ~800MB on my system. Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d --- M be/src/common/global-flags.cc M be/src/runtime/exec-env.cc 2 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/7462/4 -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7609 Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 This is cleanup that wasn't included in Part 2. Testing: Confirmed that everything (including be tests) built ok, buffered-tuple-stream-v2-test passed and that I could run a couple of basic queries. Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591 --- M be/src/exec/analytic-eval-node.cc M be/src/exec/analytic-eval-node.h M be/src/exec/hash-table-test.cc M be/src/exec/hash-table.cc M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h M be/src/exec/partitioned-aggregation-node-ir.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-aggregation-node.h M be/src/exec/partitioned-hash-join-builder-ir.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node-ir.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/partitioned-hash-join-node.h M be/src/exec/partitioned-hash-join-node.inline.h M be/src/runtime/CMakeLists.txt R be/src/runtime/buffered-tuple-stream-test.cc R be/src/runtime/buffered-tuple-stream.cc R be/src/runtime/buffered-tuple-stream.h R be/src/runtime/buffered-tuple-stream.inline.h 21 files changed, 194 insertions(+), 194 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/7609/1 -- To view, visit http://gerrit.cloudera.org:8080/7609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-5768: Better developer documentation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5768: Better developer documentation
..
Patch Set 4: Code-Review+1
(1 comment)
LGTM. I'll give other reviewers a chance to weigh in.
http://gerrit.cloudera.org:8080/#/c/7350/4/README.md
File README.md:
Line 105: | SENTRY_HOME | "${CDH_COMPONENTS_HOME}/toolchain/" | |
Should this be /sentry-?? or something?
--
To view, visit http://gerrit.cloudera.org:8080/7350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Jim Apple
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zach Amsden
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7606/1/be/src/rpc/thrift-server-test.cc
File be/src/rpc/thrift-server-test.cc:
PS1, Line 257: TEST(SslTest, StringToProtocol) {
Please add a brief description explaining what this test does, especially
between the different versions.
Also, I know it's tedious, but were you able to test it with OpenSSL versions >
1.1 and < 1.1 ?
PS1, Line 341: // AES256 is v1.2+ only.
Do we know if thrift bubbles up sensible errors for cipher-SSL version
incompatibility?
http://gerrit.cloudera.org:8080/#/c/7606/1/be/src/rpc/thrift-server.h
File be/src/rpc/thrift-server.h:
PS1, Line 31: #include "rpc/auth-provider.h"
We can change this to a forward declare right?
PS1, Line 32: #include "util/metrics.h"
Same as above
Line 165: /// is used only for password-protected .PEM files.
Should have caught this in the other review, but please add a comment for the
'ciphers' argument too.
http://gerrit.cloudera.org:8080/#/c/7606/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
PS1, Line 181: Supported versions are "
: #if OPENSSL_VERSION_NUMBER >= 0x1000100L
: "TLSv1.0, TLSv1.1 and TLSv1.2");
: #else
: "TLSv1.0");
: #endif
Should we also mention what the strings representing these different versions
are? Or do we expect users to find that from the documentation?
--
To view, visit http://gerrit.cloudera.org:8080/7606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c68a6c9658ddbfbe8025f2021fd5ed7a9dec5a5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson
Gerrit-Reviewer: Sailesh Mukil
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File bin/bootstrap_development.sh: Line 57: maven ninja-build ntp ntpdate python-dev python-setuptools postgresql Please add the following too: "wget" - For bootstrap_toolchain.py(We shouldn't assume that users already have it, even though that would be the more likely case) "libffi_dev" - For the ADLS python client (and something else, but I'm not sure what that is) "libkrb5-dev" - For kerberos libraries that we will pull in for our security code. -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
IMPALA-5546: Allow creating unpartitioned Kudu tables
This patch makes it possible to create unpartitioned, managed Kudu
tables from Impala, by making the 'PARTITION BY' clause of 'CREATE
TABLE... STORED AS KUDU' optional:
CREATE TABLE [IF NOT EXISTS] [db_name.]table_name
(col_name data_type
[kudu_column_attribute ...]
[COMMENT 'col_comment']
[, ...]
[PRIMARY KEY (col_name[, ...])]
)
[PARTITION BY kudu_partition_clause]
[COMMENT 'table_comment']
STORED AS KUDU
[TBLPROPERTIES ('key1'='value1', 'key2'='value2', ...)]
Kudu represents this as a table that is range partitioned on no
columns.
Because unpartitioned Kudu tables are inefficient for large data
sizes, and because the syntax doesn't make it explicit that the table
will be unpartitioned, there is a warning issued to encourage users
to created partitioned tables.
This patch also converts the tpch_kudu.nation and tpch_kudu.region
tables to be unpartitioned, as they are very small.
Testing:
- Updated analysis tests.
- Added e2e test that creates unpartitioned table and inserts into it.
Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a
Reviewed-on: http://gerrit.cloudera.org:8080/7446
Reviewed-by: Thomas Tauber-Marshall
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
6 files changed, 58 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: > I'm testing this out. It worked pretty well on the Ubuntu 16 system I tried out. I was able to build Impala, create a database, load data into HDFS, create an external table, create a managed table from the external, and run queries. The dependencies needed will be much more easily managed here than with Chef, I think. The comments I left might help out a build/environment Impala novice, who is likely to try to re-run this script numerous times until he gets a success notice. -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File bin/bootstrap_development.sh: PS3, Line 145: time -p ./buildall.sh -noclean -format -testdata I'm torn about this, because it takes hours. Maybe consider ./buildall.sh -noclean -format -notests : that lets a user start playing with Impala sooner. Alternatively, consider commented out lines where users can change what happens here. -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1004/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1003/ -- To view, visit http://gerrit.cloudera.org:8080/7608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7608 Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. IMPALA-5774: Prevent FindInSet() from reading off end of string Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d --- M be/src/exprs/string-functions-ir.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/7608/1 -- To view, visit http://gerrit.cloudera.org:8080/7608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I541c8e6bb712e380f9610d6bfa35e2d515a31d1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1000/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 3:
(3 comments)
LGTM. Please address the question in ~MemTracker().
http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:
PS3, Line 114: if (consumption_metric_ == nullptr) {
Why this change ? Why not always have the DCHECK() below ?
PS3, Line 200: Close(); // Various backend tests do not call Close(). Clean up
for them.
Ideally, we'd like to have a DCHECK(closed_) here if we fix up all backend
tests.
http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
Line 80: // No more tracked memory should be used by the query after this
point, so we can close
nit: long line
--
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Henry Robinson
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7606 Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. IMPALA-5743: Support TLS version configuration for Thrift servers * Add --ssl_minimum_version which controls the minimum SSL/TLS version that clients and servers will use when negotiating a secure connection. * Two kinds of version specification are allowed: 'TLSv1.1' enables TLSv1.1 and all subsequent verisons. 'TLSv1.1_only' enables only TLSv1.1. The latter is not exposed in user-facing text as it is typically only used for testing. * Handle case where platform may not support TLSv1.1 or v1.2 by checking OpenSSL version number. * Bump Thrift toolchain version to -p10. Testing: * New tests in thrift-server-test.cc. In particular, test all 36 configurations of client and server protocol versions, and ensure that the expected successes or failures are seen. Change-Id: I4c68a6c9658ddbfbe8025f2021fd5ed7a9dec5a5 --- M be/src/rpc/thrift-client.cc M be/src/rpc/thrift-client.h M be/src/rpc/thrift-server-test.cc M be/src/rpc/thrift-server.cc M be/src/rpc/thrift-server.h M be/src/service/impala-server.cc M bin/impala-config.sh 7 files changed, 176 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/7606/1 -- To view, visit http://gerrit.cloudera.org:8080/7606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c68a6c9658ddbfbe8025f2021fd5ed7a9dec5a5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File bin/bootstrap_development.sh: PS3, Line 127: export IMPALA_HOME="$(pwd)" What do you think about setting this in .bashrc also? -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7605 Change subject: IMPALA-5769: Add periodic minidump cleanup .. IMPALA-5769: Add periodic minidump cleanup Minidumps can be written by sending SIGUSR1 to our daemon processes. That way, an arbitrary number of minidump files can be created. This change adds minidump cleanup to the periodic log file cleanup to effectively bound the maximum number of minidumps we keep around. Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980 --- M be/src/common/init.cc M be/src/util/minidump.cc M be/src/util/minidump.h M tests/custom_cluster/test_breakpad.py 4 files changed, 47 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/7605/1 -- To view, visit http://gerrit.cloudera.org:8080/7605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 1: Please squash this commit into https://gerrit.cloudera.org/#/c/7588/. -- To view, visit http://gerrit.cloudera.org:8080/7603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada Gerrit-HasComments: No
[native-toolchain-CR] Bump Kudu version to 943b1ae
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 943b1ae .. Bump Kudu version to 943b1ae Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 --- M buildall.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Matthew Jacobs: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall
[native-toolchain-CR] Bump Kudu version to 943b1ae
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 943b1ae .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Pranay Singh has uploaded a new patch set (#2). Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. IMPALA-1478: Improve error message when subquery is used in the ON clause Fix: Print the error stating that "Suquery not allowed in the ON clause" Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2 --- M fe/src/main/java/org/apache/impala/analysis/TableRef.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7588/2 -- To view, visit http://gerrit.cloudera.org:8080/7588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada
[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7603 Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. IMPALA-1478: Improve error message when subquery is used in the ON clause Fix: Add test case for testing the failure when a subquery is used in the ON clause. Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff --- M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/7603/1 -- To view, visit http://gerrit.cloudera.org:8080/7603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh
[native-toolchain-CR] Bump Kudu version to 943b1ae
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 943b1ae .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[native-toolchain-CR] Bump Kudu version to 943b1ae
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7601 Change subject: Bump Kudu version to 943b1ae .. Bump Kudu version to 943b1ae Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 --- M buildall.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/01/7601/1 -- To view, visit http://gerrit.cloudera.org:8080/7601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I15c1f0a9ff0002b7bda6f43e2fd5156ef21a04e6 Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1002/ -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Code-Review+2 rebase. -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Michael Brown has posted comments on this change.
Change subject: IMPALA-4407: Move Impala setup procedures to main repo
..
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh
File bin/bootstrap_development.sh:
PS3, Line 90: # IMPALA-3932, IMPALA-3926
: SET_LD_LIBRARY_PATH='export
LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}'
: echo "$SET_LD_LIBRARY_PATH" >> ~/.bashrc
: eval "$SET_LD_LIBRARY_PATH"
1. Is this needed for Ubuntu 14? I don't do this on my personal Ubuntu 14
system, and IMPALA-3932 says "This works in my experience if the system version
is newer than the toolchain version."
2. If you run this script again and again it'll keep appending to .bashrc.
PS3, Line 96: sudo -u postgres psql -c "CREATE ROLE hiveuser LOGIN PASSWORD
'password';" postgres
If you run this script twice, this line always fails. Could this be enhanced to
succeed if the ROLE already exists?
PS3, Line 115: echo "NoHostAuthenticationForLocalhost yes" >> ~/.ssh/config
It might be polite to have a prompt for this since it's a security change.
PS3, Line 118: echo "127.0.0.1 $(hostname -s) $(hostname)" | sudo tee -a
/etc/hosts
: sudo sed -i 's/127.0.1.1/127.0.0.1/g' /etc/hosts
This will keep appending to /etc/hosts if you run the script more than once.
PS3, Line 124: echo "* - nofile 1048576" | sudo tee -a /etc/security/limits.conf
1. This keeps appending to limits.conf
2. Should this be changed to be restricted only to the current $USER?
PS3, Line 131: git clone https://github.com/cloudera/impala-lzo.git
: ln -s impala-lzo Impala-lzo
: git clone https://github.com/cloudera/hadoop-lzo.git
This fails if you run the script twice. Could you add -d tests here similar for
what you do with Impala?
PS3, Line 139: if [[ $VERSION = "14.04" ]]
: then
: unset LD_LIBRARY_PATH
: fi
Oh, this sort of answers my question above. What about when the user creates a
new shell session? He'll have sourced the modified .bashrc that sets
LD_LIBRARY_PATH.
--
To view, visit http://gerrit.cloudera.org:8080/7587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple
Gerrit-Reviewer: Jim Apple
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Sailesh Mukil
Gerrit-Reviewer: Tim Armstrong
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File bin/bootstrap_development.sh: PS3, Line 21: system : # configurations, so it is best to run this in a fresh install. It also sets up the : # .bashrc of the calling user with some environment variables I know that the impala-setup rep didn't do this, but do you think it would be a good idea to have a warning at the beginning of the script stating that it will clobber the .bashrc and some of the system configuration, with a: "Do you want to continue? [y/n]" prompt below that warning? -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 8: Code-Review+2 (8 comments) Thanks for the review. Will also wait for Henry's final comments/confirmation. Carry +2. http://gerrit.cloudera.org:8080/#/c/7542/8//COMMIT_MSG Commit Message: PS8, Line 7: dummy 'use_krpc' flag > The flag is not really dummy, right ? We are just using dummy implementatio Done Line 20: DataStream*Base. > Using pure virtual base class may result in code duplication but the curren Done PS8, Line 27: Since having both the Thrift and KRPC implementations of the : DataStream* classes are only expected to be temporary for now, this : was written and optimized with the end goal of having only the KRPC : versions of the DataStreamMgr/Recvr, at which point we will get rid : of the DataStream*Base classes, the Thrift versions of the classes : and rename KrpcDataStream* to DataStream*. We will also rename all : the references that the clients have to DataStream*Base to DataStream*. > May remove or shorten this entire paragraph if you take the one line sugges Done http://gerrit.cloudera.org:8080/#/c/7542/8/be/src/runtime/data-stream-mgr-base.h File be/src/runtime/data-stream-mgr-base.h: PS8, Line 35: enforces a basic interface > defines the basic interface Done PS8, Line 36: , one each for Thrift and KRPC. > for thrift and KRPC respectively. There's nothing for them to be respective to, as Henry mentioned in his comments in the previous patchset. http://gerrit.cloudera.org:8080/#/c/7542/8/be/src/runtime/data-stream-recvr-base.h File be/src/runtime/data-stream-recvr-base.h: PS8, Line 32: enforces a basic interface > defines the basic interface Done PS8, Line 33: , one each for Thrift and KRPC > for thrift and KRPC respectively. There's nothing for them to be respective to, as Henry mentioned in his comments in the previous patchset. http://gerrit.cloudera.org:8080/#/c/7542/8/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: PS8, Line 92: Clients of the implementations of DataStreamMgrBase should not use these functions > Clients of DataStreamMgrBase should use stream_mgr() unless ... Done -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7542 to look at the new patch set (#9). Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add 'use_krpc' flag and create DataStream interface This patch introduces a 'use_krpc' flag and creates an abstract interface for the DataStreamRecvr/Mgr. The 'use_krpc' flag defaults to 'false'. Cluster startup will abort with an error if the flag is switched to 'true'. The DataStreamSender implements the same virtual interface as the DataSink, so a pure virtual class for the DataStreamSender would essentially be an empty class. Therefore, it is not implemented. The new interfaces are pure virtual base classes and are named DataStream*Base. Using pure virtual base classes may result in code duplication but the current approach is to optimize for the eventual removal of the thrift implementations. Stubs for the Krpc implementations are also introduced and are named KrpcDataStream*. They currently only abort with a fatal error if they are used. Their actual implementations will be filled in a later patch. When the time comes to standardize on the KRPC implementations of DataStream*Base, we will get rid of the DataStream*Base classes and the Thrift versions of the classes and rename KrpcDataStream* to DataStream*. We will also rename all the references that the clients have to DataStream*Base to DataStream*. Also did some spurious includes cleanup. Change-Id: I5d52245154e910529a68f53049520238eca16241 --- M be/src/exec/data-sink.cc M be/src/exec/exchange-node.cc M be/src/exec/exchange-node.h M be/src/runtime/CMakeLists.txt A be/src/runtime/data-stream-mgr-base.h M be/src/runtime/data-stream-mgr.cc M be/src/runtime/data-stream-mgr.h A be/src/runtime/data-stream-recvr-base.h M be/src/runtime/data-stream-recvr.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/fragment-instance-state.cc A be/src/runtime/krpc-data-stream-mgr.cc A be/src/runtime/krpc-data-stream-mgr.h A be/src/runtime/krpc-data-stream-recvr.cc A be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/service/impala-server.cc 20 files changed, 441 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7542/9 -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables .. Patch Set 4: Code-Review+2 (1 comment) Carrying forward. http://gerrit.cloudera.org:8080/#/c/7446/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: Line 278: Unpartitioned Kudu tables are inefficient for large data sizes. Turns out, our test framework doesn't support both 'ERRORS' and 'DML_RESULTS' in the same test case, so I separated it out into two tests. -- To view, visit http://gerrit.cloudera.org:8080/7446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1001/ -- To view, visit http://gerrit.cloudera.org:8080/7446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Hello Impala Public Jenkins, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7446
to look at the new patch set (#4).
Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
..
IMPALA-5546: Allow creating unpartitioned Kudu tables
This patch makes it possible to create unpartitioned, managed Kudu
tables from Impala, by making the 'PARTITION BY' clause of 'CREATE
TABLE... STORED AS KUDU' optional:
CREATE TABLE [IF NOT EXISTS] [db_name.]table_name
(col_name data_type
[kudu_column_attribute ...]
[COMMENT 'col_comment']
[, ...]
[PRIMARY KEY (col_name[, ...])]
)
[PARTITION BY kudu_partition_clause]
[COMMENT 'table_comment']
STORED AS KUDU
[TBLPROPERTIES ('key1'='value1', 'key2'='value2', ...)]
Kudu represents this as a table that is range partitioned on no
columns.
Because unpartitioned Kudu tables are inefficient for large data
sizes, and because the syntax doesn't make it explicit that the table
will be unpartitioned, there is a warning issued to encourage users
to created partitioned tables.
This patch also converts the tpch_kudu.nation and tpch_kudu.region
tables to be unpartitioned, as they are very small.
Testing:
- Updated analysis tests.
- Added e2e test that creates unpartitioned table and inserts into it.
Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
6 files changed, 58 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/7446/4
--
To view, visit http://gerrit.cloudera.org:8080/7446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 2: Code-Review+1 Carrying forward +1 -- To view, visit http://gerrit.cloudera.org:8080/7577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1528661e5df6d9732ebfeb414576c82ec5c92241 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1000/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f98d1b2f514d7afdee8d86a45167905b272ca4d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote .. IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote Change-Id: I0f98d1b2f514d7afdee8d86a45167905b272ca4d Reviewed-on: http://gerrit.cloudera.org:8080/7600 Reviewed-by: Henry Robinson Tested-by: Impala Public Jenkins --- M LICENSE.txt 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f98d1b2f514d7afdee8d86a45167905b272ca4d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/998/ -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
