[Impala-ASF-CR] [DOCS] Fold some lines
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Fold some lines .. [DOCS] Fold some lines Putting on a separate line causes an extra leading blank line in PDF output. (I think that's a bug in the PDF transform, but what can you do...) I took one file that had a few instances of such examples, and folded the first line of the code example onto the same line as the tag. Using this minor change to demo upstream -> downstream cherry-picking techniques. Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Reviewed-on: http://gerrit.cloudera.org:8080/7417 Reviewed-by: Michael BrownReviewed-by: Laurel Hale Tested-by: Impala Public Jenkins --- M docs/topics/impala_connecting.xml 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Brown: Looks good to me, approved Laurel Hale: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] [DOCS] Fold some lines
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fold some lines
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/148/ -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fold some lines
Laurel Hale has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Code-Review+1 PDF build looks good. -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fold some lines
Michael Brown has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fold some lines
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7417 Change subject: [DOCS] Fold some lines .. [DOCS] Fold some lines Putting on a separate line causes an extra leading blank line in PDF output. (I think that's a bug in the PDF transform, but what can you do...) I took one file that had a few instances of such examples, and folded the first line of the code example onto the same line as the tag. Using this minor change to demo upstream -> downstream cherry-picking techniques. Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 --- M docs/topics/impala_connecting.xml 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/7417/1 -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell