[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change.

Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..


Patch Set 4: Code-Review+2

Carrying the +2-- was missing changes to the config files for running kudu. 

They started requiring a flag to enable debug/unsafe options which we use.

-- 
To view, visit http://gerrit.cloudera.org:8080/4420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No


[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4420

to look at the new patch set (#4).

Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..

Bump Kudu version to 1.0-RC1 and add support for new OSes

Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
---
M bin/impala-config.sh
M testdata/cluster/node_templates/cdh5/etc/kudu/master.conf.tmpl
M testdata/cluster/node_templates/cdh5/etc/kudu/tserver.conf.tmpl
3 files changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/4420/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 


[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change.

Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..


Patch Set 3: Verified-1

Build failed: 
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/205/

-- 
To view, visit http://gerrit.cloudera.org:8080/4420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No


[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change.

Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4420/2/bin/impala-config.sh
File bin/impala-config.sh:

PS2, Line 136: centos5 | debian6 | enterprise*5 | redhat*5 | suse* )
 : KUDU_IS_SUPPORTED=false;;
Wouldn't it make more sense to list the supported OSes instead? I mean, do we 
really support debian5? :)


-- 
To view, visit http://gerrit.cloudera.org:8080/4420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-HasComments: Yes


[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4420

to look at the new patch set (#2).

Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..

Bump Kudu version to 1.0-RC1 and add support for new OSes

Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/4420/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Dimitris Tsirogiannis