[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Fix distcc instructions to help users know they must set BUILD_FARM

While I'm here, remove an errant reference to IMPALA_AUX_TEST_HOME.

Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Reviewed-on: http://gerrit.cloudera.org:8080/4868
Reviewed-by: Jim Apple 
Tested-by: Tim Armstrong 
---
M bin/distcc/README.md
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Tim Armstrong: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Patch Set 3:

> Is this ready to merge? While we wait for some clean test runs, I
 > think we can go ahead with this change since it is doc-only.

Yes, this is ready to merge

-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Patch Set 3:

Is this ready to merge? While we wait for some clean test runs, I think we can 
go ahead with this change since it is doc-only.

-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Patch Set 3: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/4868/2/bin/distcc/README.md
File bin/distcc/README.md:

PS2, Line 60: Switching 
> Switching
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4868

to look at the new patch set (#3).

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..

Fix distcc instructions to help users know they must set BUILD_FARM

While I'm here, remove an errant reference to IMPALA_AUX_TEST_HOME.

Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
---
M bin/distcc/README.md
1 file changed, 10 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/4868/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change.

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4868/2/bin/distcc/README.md
File bin/distcc/README.md:

PS2, Line 60: Switiching
Switching


-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2).

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..

Fix distcc instructions to help users know they must set BUILD_FARM

While I'm here, remove an errant reference to IMPALA_AUX_TEST_HOME.

Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
---
M bin/distcc/README.md
1 file changed, 9 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/4868/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dimitris Tsirogiannis 


[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4868

Change subject: Fix distcc instructions to help users know they must set 
BUILD_FARM
..

Fix distcc instructions to help users know they must set BUILD_FARM

Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
---
M bin/distcc/README.md
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/4868/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I323006110d77de05b251d9fc2578774a78e5509b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple